From: Greg KH <gregkh@linuxfoundation.org>
To: Hui Wang <hui.wang@canonical.com>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
sashal@kernel.org, hvilleneuve@dimonoff.com
Subject: Re: [stble-kernel][5.15.y][5.10.y][PATCH v2] serial: sc16is7xx: the reg needs to shift in regmap_noinc
Date: Tue, 10 Dec 2024 13:15:46 +0100 [thread overview]
Message-ID: <2024121020-abstract-ashy-cbe6@gregkh> (raw)
In-Reply-To: <20241210113126.46056-1-hui.wang@canonical.com>
On Tue, Dec 10, 2024 at 07:31:26PM +0800, Hui Wang wrote:
> Recently we found the fifo_read() and fifo_write() are broken in our
> 5.15 and 5.4 kernels after cherry-pick the commit e635f652696e
> ("serial: sc16is7xx: convert from _raw_ to _noinc_ regmap functions
> for FIFO"), that is because the reg needs to shift if we don't
> cherry-pick a prerequisite commit 3837a0379533 ("serial: sc16is7xx:
> improve regmap debugfs by using one regmap per port").
>
> It is hard to backport the prerequisite commit to 5.15.y and 5.10.y
> due to the significant conflict. To be safe, here fix it by shifting
> the reg as regmap_volatile() does.
Please try, submit the series of upstream commits first and then if it's
too rough, we can evaluate it later. As-is, I can't take this, sorry.
greg k-h
next prev parent reply other threads:[~2024-12-10 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 11:31 [stble-kernel][5.15.y][5.10.y][PATCH v2] serial: sc16is7xx: the reg needs to shift in regmap_noinc Hui Wang
2024-12-10 12:15 ` Greg KH [this message]
2024-12-10 12:51 ` Hui Wang
2024-12-10 19:25 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024121020-abstract-ashy-cbe6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=hvilleneuve@dimonoff.com \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.