From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: David Wei <dw@davidwei.uk>, Yunsheng Lin <linyunsheng@huawei.com>,
netdev@vger.kernel.org,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v3 3/3] bnxt_en: handle tpa_info in queue API implementation
Date: Wed, 11 Dec 2024 16:48:41 -0800 [thread overview]
Message-ID: <20241211164841.44cba0ad@kernel.org> (raw)
In-Reply-To: <CACKFLik1-rQB2QHY1pZ3eF0GYGUCgXFHvhh50DNboXV+A7MCuA@mail.gmail.com>
On Wed, 11 Dec 2024 09:11:55 -0800 Michael Chan wrote:
> > At the time I just wanted something to work, and not having
> > napi_enable/disable() made it work. :) Looking back though it does seem
> > odd, so I'll try putting it back.
>
> Yeah, I think it makes sense to add napi_disable().
+1, TBH I'm not sure how we avoid hitting the warning which checks
if NAPI is "scheduled" in page_pool_disable_direct_recycling().
But, Yunsheng, I hope it is clear that the sync RCU is needed even
if driver disables NAPI for the reconfiguration. Unless you see a
RCU sync in napi_disable() / napi_enable()..
next prev parent reply other threads:[~2024-12-12 0:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 4:10 [PATCH net v3 0/3] bnxt_en: support header page pool in queue API David Wei
2024-12-04 4:10 ` [PATCH net v3 1/3] bnxt_en: refactor tpa_info alloc/free into helpers David Wei
2024-12-04 4:10 ` [PATCH net v3 2/3] bnxt_en: refactor bnxt_alloc_rx_rings() to call bnxt_alloc_rx_agg_bmap() David Wei
2024-12-04 4:10 ` [PATCH net v3 3/3] bnxt_en: handle tpa_info in queue API implementation David Wei
2024-12-10 12:25 ` Yunsheng Lin
2024-12-10 18:14 ` David Wei
2024-12-11 12:32 ` Yunsheng Lin
2024-12-11 16:10 ` David Wei
2024-12-11 17:11 ` Michael Chan
2024-12-12 0:48 ` Jakub Kicinski [this message]
2024-12-12 11:23 ` Yunsheng Lin
2024-12-12 14:56 ` Jakub Kicinski
2024-12-13 12:17 ` Yunsheng Lin
2024-12-31 11:49 ` Yunsheng Lin
2024-12-16 21:41 ` David Wei
2024-12-16 22:48 ` Michael Chan
2024-12-16 22:59 ` David Wei
2024-12-04 22:43 ` [PATCH net v3 0/3] bnxt_en: support header page pool in queue API Michael Chan
2024-12-05 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211164841.44cba0ad@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=linyunsheng@huawei.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.