From: Jakub Kicinski <kuba@kernel.org>
To: <jianqi.ren.cn@windriver.com>
Cc: <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<sashal@kernel.org>, <jamie.bainbridge@gmail.com>,
<jdamato@fastly.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6.1.y] net: napi: Prevent overflow of napi_defer_hard_irqs
Date: Wed, 11 Dec 2024 20:07:39 -0800 [thread overview]
Message-ID: <20241211200739.47686258@kernel.org> (raw)
In-Reply-To: <20241211040304.3212711-1-jianqi.ren.cn@windriver.com>
On Wed, 11 Dec 2024 12:03:04 +0800 jianqi.ren.cn@windriver.com wrote:
> From: Joe Damato <jdamato@fastly.com>
>
> [ Upstream commit 08062af0a52107a243f7608fd972edb54ca5b7f8 ]
>
> In commit 6f8b12d661d0 ("net: napi: add hard irqs deferral feature")
> napi_defer_irqs was added to net_device and napi_defer_irqs_count was
> added to napi_struct, both as type int.
>
> This value never goes below zero, so there is not reason for it to be a
> signed int. Change the type for both from int to u32, and add an
> overflow check to sysfs to limit the value to S32_MAX.
Could you explain why you want to backport this change to stable?
next prev parent reply other threads:[~2024-12-12 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 4:03 [PATCH 6.1.y] net: napi: Prevent overflow of napi_defer_hard_irqs jianqi.ren.cn
2024-12-11 16:32 ` Sasha Levin
2024-12-12 4:07 ` Jakub Kicinski [this message]
2024-12-12 7:06 ` Ren, Jianqi (Jacky) (CN)
2024-12-12 11:41 ` Greg KH
2024-12-12 14:50 ` Jakub Kicinski
2024-12-12 15:17 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2024-12-11 10:10 jianqi.ren.cn
2024-12-11 16:32 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211200739.47686258@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamie.bainbridge@gmail.com \
--cc=jdamato@fastly.com \
--cc=jianqi.ren.cn@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.