From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF83122913A for ; Wed, 11 Dec 2024 13:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733924781; cv=none; b=gWNoKhvPLPCsZJyo/rV5wF4D2MBGsOornWM9PqfWEWlRmHvwuODhvWv7aiNk7t5P/OzKsuW7WQ+F7/4MCI0Jj6XErBJWw33VbBViUp47lyU7D4M5l7SGJahs5M2DqRp7Rj+evrUfTXvAunvSMfrty3Ef7TUxVVM0Wm7w+2AYuWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733924781; c=relaxed/simple; bh=HWXtI3f+E3Tiyx/D2Axaq2OXYBsQB19LK8Y6k/NMFa4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dUOgC+Nen81EYGgdrT9r25wnnQyky65FNxQ/TGrLLI8t63AzyHfL9/pUq8r1zHwgq4orYjju1o+JAPfGpBvEy9SeWwlzUfAxl6OfGdiBdyxBBvlLuC/r4ZmjkdZp4vfGXjk6tCPH2rjj02ZlSN0lGVI4p9CPrw8hAmGvZPuAo0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GNzfBd67; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GNzfBd67" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D15CFC4CED2; Wed, 11 Dec 2024 13:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1733924781; bh=HWXtI3f+E3Tiyx/D2Axaq2OXYBsQB19LK8Y6k/NMFa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GNzfBd674DDIOAg5OzFCuPFaVwl6fbNgxNIu1CkZanOXGwI+NrhDOXBsHHeBPkeTt UrNtTMANfXbCfoJE2TQTtQHOA9Oan73/P823xcRHVCqUJjbwBCE3R/+oipXBUom/gA +wKAaoiJkQqd627paFrzhARWOUajZ4uSAjbZC84c= Date: Wed, 11 Dec 2024 14:46:19 +0100 From: Greg Kroah-Hartman To: Marek =?iso-8859-1?Q?Marczykowski-G=F3recki?= Cc: Ard Biesheuvel , =?iso-8859-1?Q?J=FCrgen_Gro=DF?= , Jason Andryuk , Stefano Stabellini , Oleksandr Tyshchenko , regressions@lists.linux.dev, xen-devel Subject: Re: [REGRESSION] Linux 6.6.64 crashes when booting as PVH domU Message-ID: <2024121144-false-playtime-968e@gregkh> References: Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Dec 11, 2024 at 02:39:33PM +0100, Marek Marczykowski-Górecki wrote: > On Wed, Dec 11, 2024 at 01:37:52PM +0100, Ard Biesheuvel wrote: > > (cc Greg) > > > > On Wed, 11 Dec 2024 at 13:30, Marek Marczykowski-Górecki > > wrote: > > > > > > On Wed, Dec 11, 2024 at 01:24:08PM +0100, Ard Biesheuvel wrote: > > > > On Wed, 11 Dec 2024 at 12:53, Jürgen Groß wrote: > > > > > > > > > > Jason, Ard, > > > > > > > > > > I guess there are some prereq patches missing in stable 6.6.y branch? > > > > > > > > > > > > > > > Juergen > > > > > > > > > > On 11.12.24 12:41, Marek Marczykowski-Górecki wrote: > > > > > > Hi, > > > > > > > > > > > > With Linux 6.6.64 I get the following crash on domU boot: > > > > > > > > > > > > (XEN) d5v0 Triple fault - invoking HVM shutdown action 1 > > > > > > (XEN) *** Dumping Dom5 vcpu#0 state: *** > > > > > > (XEN) ----[ Xen-4.19.0 x86_64 debug=n Tainted: M ]---- > > ... > > > > > > > > > > > > Linux 6.6.63 works fine. > > > > > > > > > > > > Looking at the changes, I suspect one of those: > > > > > > > > > > > > 83d123e27623 x86/pvh: Call C code via the kernel virtual mapping > > > > > > f662b4a69e1d x86/pvh: Set phys_base when calling xen_prepare_pvh() > > > > > > > > > > > > > > The second patch shouldn't have been backported. It is unnecessary, > > > > given that in the old situation, the kernel image needs to be loaded > > > > at a fixed address. And it assumes that %rbp is set to the physical > > > > load offset, but those patches were not backported. > > > > > > It has this tag: > > > > > > Stable-dep-of: e8fbc0d9cab6 ("x86/pvh: Call C code via the kernel virtual mapping") > > > > > > > That was added by the stable maintainers - someone grabbed a patch > > from the middle of an unrelated series to make e8fbc0d9cab6 apply > > without lexical conflicts. > > > > > Does it mean neither of them should be backported? > > > > > > But then, the e8fbc0d9cab6 has "Fixes:" tag (pointing at very old > > > commit). > > > > > > > If someone thinks e8fbc0d9cab6 should be backported, they should > > rebase it onto v6.6.y, not backport random other patches until > > git-apply stops complaining. And ideally, someone would build and boot > > the result to check whether it works. > > > > For now, it would be better to revert both. > > I can confirm that reverting both commits fixes the issue. Ok, thanks, let me go rip all of these out and do a new release now to fix the issue. Sorry about that, and thanks so much for the testing and letting us know! greg k-h