From: Christoph Hellwig <hch@lst.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-pci: define pr_fmt()
Date: Thu, 12 Dec 2024 07:22:41 +0100 [thread overview]
Message-ID: <20241212062241.GA5586@lst.de> (raw)
In-Reply-To: <877fbfffe61b9b17bfd7d4338f879e27b33e9b71.1733737768.git.baruch@tkos.co.il>
On Mon, Dec 09, 2024 at 11:49:28AM +0200, Baruch Siach wrote:
> Make pr_err() call from nvme_find_rq() produce messages with prefix, to
> ease debug.
Really? If you want useful information there I don't think the prefix
is very useful. You'd be better off passing the nvme_ctrl and then
use dev_err based on that.
prev parent reply other threads:[~2024-12-12 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 9:49 [PATCH] nvme-pci: define pr_fmt() Baruch Siach
2024-12-12 6:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212062241.GA5586@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=baruch@tkos.co.il \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.