From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
wojciech.drewek@intel.com, mateusz.polchlopek@intel.com,
joe@perches.com, horms@kernel.org, jiri@resnulli.us,
apw@canonical.com, lukas.bulwahn@gmail.com,
dwaipayanray1@gmail.com, Igor Bagnucki <igor.bagnucki@intel.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next 6/7] ice: dump ethtool stats and skb by Tx hang devlink health reporter
Date: Thu, 12 Dec 2024 19:00:40 -0800 [thread overview]
Message-ID: <20241212190040.3b99b7af@kernel.org> (raw)
In-Reply-To: <20241211223231.397203-7-anthony.l.nguyen@intel.com>
On Wed, 11 Dec 2024 14:32:14 -0800 Tony Nguyen wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> Print the ethtool stats and skb diagnostic information as part of Tx hang
> devlink health dump.
>
> Move the declarations of ethtool functions that devlink health uses out
> to a new file: ice_ethtool_common.h
>
> To utilize our existing ethtool code in this context, convert it to
> non-static.
This is going too far, user space is fully capable of capturing this
data. It gets a netlink notification when health reporter flips to
a bad state. I think Jiri worked on a daemon what could capture more
data from user space ? I may be misremembering...
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-13 3:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 22:32 [PATCH net-next 0/7][pull request] ice: add support for devlink health events Tony Nguyen
2024-12-11 22:32 ` [PATCH net-next 1/7] checkpatch: don't complain on _Generic() use Tony Nguyen
2024-12-13 3:01 ` Jakub Kicinski
2024-12-13 5:58 ` Joe Perches
2024-12-11 22:32 ` [PATCH net-next 2/7] devlink: add devlink_fmsg_put() macro Tony Nguyen
2024-12-11 22:32 ` [PATCH net-next 3/7] devlink: add devlink_fmsg_dump_skb() function Tony Nguyen
2024-12-11 22:32 ` [PATCH net-next 4/7] ice: rename devlink_port.[ch] to port.[ch] Tony Nguyen
2024-12-12 6:08 ` Kalesh Anakkur Purayil
2024-12-11 22:32 ` [PATCH net-next 5/7] ice: add Tx hang devlink health reporter Tony Nguyen
2024-12-11 22:32 ` [PATCH net-next 6/7] ice: dump ethtool stats and skb by " Tony Nguyen
2024-12-13 3:00 ` Jakub Kicinski [this message]
2024-12-16 4:53 ` Przemek Kitszel
2024-12-16 12:58 ` Przemek Kitszel
2025-02-11 14:10 ` Jiri Pirko
2024-12-11 22:32 ` [PATCH net-next 7/7] ice: Add MDD logging via devlink health Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212190040.3b99b7af@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=igor.bagnucki@intel.com \
--cc=jiri@resnulli.us \
--cc=joe@perches.com \
--cc=lukas.bulwahn@gmail.com \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.