Re: [yocto-patches] [meta-rockchip PATCH v2 0/2] bsp: rkbin: bump to latest commit in master

[Trevor Woerner <twoerner@gmail.com>]

On Thu 2024-11-28 @ 04:58:48 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> We've been hit by random RCU stalls, system hangs or resets on some (not
> all) of our RK3588-based products running some old BL31/DDR init
> binaries.
> 
> Upgrading to latest commit in master branch seems to mitigate those
> issues, so let's do that.
> 
> Only build tested.

I have finally gotten around to testing before and after images of your
patchset. This was complicated by the fact that the u-boot and kernel for the
radxa-zero-3 stopped working recently, so I needed updates for that in order
to test everything.

I was able to confirm all of the changes work on hardware except for the
rk3308.

	in order to test		i have a
	^^^^^^^^^^^^^^^^		^^^^^^^^
	rk3308				rock-pi-s
	rk3566				radxa-zero-3e
	rk3568				rock-3a
	rk3588s				rock-5a
	rk3588				rock-5b

In all cases but the rk3308 I have nice before and after captures, clearly
showing the old version numbers then the new version numbers.

In the case of the rk3308 this patch set is moving from v2.07 to v2.10, but
here's what the before looks like on the rock-pi-s:


	DDR Version V1.26
	REGFB: 0x00000032, 0x00000032
	In
	589MHz
	DDR3
	 Col=10 Bank=8 Row=14 Size=256MB
	msch:1
	Returning to boot ROM...

	U-Boot SPL 2024.04 (Apr 03 2024 - 02:37:23 +0000)
	Trying to boot from MMC2


	U-Boot 2024.04 (Apr 03 2024 - 02:37:23 +0000)

	Model: Radxa ROCK Pi S
	DRAM:  256 MiB (effective 254 MiB)
	Core:  281 devices, 21 uclasses, devicetree: separate
	MMC:   mmc@ff480000: 1, mmc@ff490000: 0, mmc@ff4a0000: 2
	Loading Environment from MMC... OK

and the after:


	DDR Version V1.26
	REGFB: 0x00000032, 0x00000033
	In
	589MHz
	DDR3
	 Col=10 Bank=8 Row=14 Size=256MB
	msch:1
	Returning to boot ROM...

	U-Boot SPL 2024.10-dirty (Oct 07 2024 - 14:54:35 +0000)
	Trying to boot from MMC2
	## Checking hash(es) for config config-1 ... OK
	## Checking hash(es) for Image atf-1 ... sha256+ OK
	## Checking hash(es) for Image u-boot ... sha256+ OK
	## Checking hash(es) for Image fdt-1 ... sha256+ OK
	## Checking hash(es) for Image atf-2 ... sha256+ OK


	U-Boot 2024.10-dirty (Oct 07 2024 - 14:54:35 +0000)

	Model: Radxa ROCK Pi S
	DRAM:  256 MiB (effective 254 MiB)
	Core:  293 devices, 30 uclasses, devicetree: separate
	MMC:   mmc@ff480000: 1, mmc@ff490000: 0, mmc@ff4a0000: 2
	Loading Environment from MMC... Reading from MMC(1)... OK

So I'm not sure what's going on here. But I'm happy with the patchset
otherwise.

> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
> Changes in v2:
> - use version and filename variables instead of using glob pattern for
>   path matching the DDR init binaries,
> - Link to v1: https://lore.kernel.org/r/20241127-rkbin-bump-v1-0-b90b6c04a88f@cherry.de
> 
> ---
> Quentin Schulz (2):
>       bsp: rkbin: rkbin-ddr: use version and file variables for path matching
>       bsp: rkbin: bump to latest commit in master branch
> 
>  README                                      | 15 +++++++++++++++
>  recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb | 20 ++++++++++++++++----
>  recipes-bsp/rkbin/rockchip-rkbin.inc        |  4 ++--
>  3 files changed, 33 insertions(+), 6 deletions(-)
> ---
> base-commit: 3a8be31581651ced6c27f5bad1333064e513a8f0
> change-id: 20241127-rkbin-bump-4cdfb23aa49f
> 
> Best regards,
> -- 
> Quentin Schulz <quentin.schulz@cherry.de>
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#857): https://lists.yoctoproject.org/g/yocto-patches/message/857
> Mute This Topic: https://lists.yoctoproject.org/mt/109823578/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>