All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: jsmart2021@gmail.com, justin.tee@broadcom.com,
	Justin Tee <justintee8345@gmail.com>
Subject: [PATCH 02/10] lpfc: Restrict the REG_FCFI MAM field to FCoE adapters only
Date: Thu, 12 Dec 2024 15:33:01 -0800	[thread overview]
Message-ID: <20241212233309.71356-3-justintee8345@gmail.com> (raw)
In-Reply-To: <20241212233309.71356-1-justintee8345@gmail.com>

Qualify setting the REG_FCFI MAM field to FCoE adapters only by keying
off HBA_FCOE_MODE phba->hba_flag.  The field is not applicable to FC
adapters.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_mbox.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c
index e98f1c2b2220..fb6dbcb86c09 100644
--- a/drivers/scsi/lpfc/lpfc_mbox.c
+++ b/drivers/scsi/lpfc/lpfc_mbox.c
@@ -2524,8 +2524,10 @@ lpfc_reg_fcfi(struct lpfc_hba *phba, struct lpfcMboxq *mbox)
 		bf_set(lpfc_reg_fcfi_rq_id1, reg_fcfi, REG_FCF_INVALID_QID);
 
 		/* addr mode is bit wise inverted value of fcf addr_mode */
-		bf_set(lpfc_reg_fcfi_mam, reg_fcfi,
-		       (~phba->fcf.addr_mode) & 0x3);
+		if (test_bit(HBA_FCOE_MODE, &phba->hba_flag)) {
+			bf_set(lpfc_reg_fcfi_mam, reg_fcfi,
+			       (~phba->fcf.addr_mode) & 0x3);
+		}
 	} else {
 		/* This is ONLY for NVMET MRQ == 1 */
 		if (phba->cfg_nvmet_mrq != 1)
-- 
2.38.0


  parent reply	other threads:[~2024-12-12 23:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 23:32 [PATCH 00/10] Update lpfc to revision 14.4.0.7 Justin Tee
2024-12-12 23:33 ` [PATCH 01/10] lpfc: Redefine incorrect type in lpfc_create_device_data Justin Tee
2024-12-12 23:33 ` Justin Tee [this message]
2024-12-12 23:33 ` [PATCH 03/10] lpfc: Delete NLP_TARGET_REMOVE flag due to obsolete usage Justin Tee
2024-12-12 23:33 ` [PATCH 04/10] lpfc: Modify handling of ADISC based on ndlp state and RPI registration Justin Tee
2024-12-12 23:33 ` [PATCH 05/10] lpfc: Add handling for LS_RJT reason explanation authentication required Justin Tee
2024-12-12 23:33 ` [PATCH 06/10] lpfc: Change lpfc_nodelist save_flags member into a bitmask Justin Tee
2024-12-12 23:33 ` [PATCH 07/10] lpfc: Update definition of firmware configuration mbox cmds Justin Tee
2024-12-12 23:33 ` [PATCH 08/10] lpfc: Add support for large fw object application layer reads Justin Tee
2024-12-12 23:33 ` [PATCH 09/10] lpfc: Update lpfc version to 14.4.0.7 Justin Tee
2024-12-12 23:33 ` [PATCH 10/10] lpfc: Copyright updates for 14.4.0.7 patches Justin Tee
2025-01-02 20:03 ` [PATCH 00/10] Update lpfc to revision 14.4.0.7 Martin K. Petersen
2025-01-10 21:16 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241212233309.71356-3-justintee8345@gmail.com \
    --to=justintee8345@gmail.com \
    --cc=jsmart2021@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.