From: Greg KH <gregkh@linuxfoundation.org>
To: Hui Wang <hui.wang@canonical.com>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
sashal@kernel.org, hvilleneuve@dimonoff.com
Subject: Re: [stable-kernel][5.15.y][PATCH 0/5] Fix a regression on sc16is7xx
Date: Thu, 12 Dec 2024 14:44:27 +0100 [thread overview]
Message-ID: <2024121241-civil-diligence-dc09@gregkh> (raw)
In-Reply-To: <20241211042545.202482-1-hui.wang@canonical.com>
On Wed, Dec 11, 2024 at 12:25:39PM +0800, Hui Wang wrote:
> Recently we found the fifo_read() and fifo_write() are broken in our
> 5.15 kernel after rebase to the latest 5.15.y, the 5.15.y integrated
> the commit e635f652696e ("serial: sc16is7xx: convert from _raw_ to
> _noinc_ regmap functions for FIFO"), but it forgot to integrate a
> prerequisite commit 3837a0379533 ("serial: sc16is7xx: improve regmap
> debugfs by using one regmap per port").
>
> And about the prerequisite commit, there are also 4 commits to fix it,
> So in total, I backported 5 patches to 5.15.y to fix this regression.
>
> 0002-xxx and 0004-xxx could be cleanly applied to 5.15.y, the remaining
> 3 patches need to resolve some conflict.
>
> Hugo Villeneuve (5):
> serial: sc16is7xx: improve regmap debugfs by using one regmap per port
> serial: sc16is7xx: remove wasteful static buffer in
> sc16is7xx_regmap_name()
> serial: sc16is7xx: remove global regmap from struct sc16is7xx_port
> serial: sc16is7xx: remove unused line structure member
> serial: sc16is7xx: change EFR lock to operate on each channels
>
> drivers/tty/serial/sc16is7xx.c | 185 +++++++++++++++++++--------------
> 1 file changed, 107 insertions(+), 78 deletions(-)
How well did you test this series? It seems you forgot about commit
133f4c00b8b2 ("serial: sc16is7xx: fix TX fifo corruption"), right?
Please do better testing and resend a working set of patches.
thanks,
greg k-h
next prev parent reply other threads:[~2024-12-12 13:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 4:25 [stable-kernel][5.15.y][PATCH 0/5] Fix a regression on sc16is7xx Hui Wang
2024-12-11 4:25 ` [stable-kernel][5.15.y][PATCH 1/5] serial: sc16is7xx: improve regmap debugfs by using one regmap per port Hui Wang
2024-12-11 16:32 ` Sasha Levin
2024-12-11 4:25 ` [stable-kernel][5.15.y][PATCH 2/5] serial: sc16is7xx: remove wasteful static buffer in sc16is7xx_regmap_name() Hui Wang
2024-12-11 16:32 ` Sasha Levin
2024-12-11 4:25 ` [stable-kernel][5.15.y][PATCH 3/5] serial: sc16is7xx: remove global regmap from struct sc16is7xx_port Hui Wang
2024-12-11 16:33 ` Sasha Levin
2024-12-11 4:25 ` [stable-kernel][5.15.y][PATCH 4/5] serial: sc16is7xx: remove unused line structure member Hui Wang
2024-12-11 16:32 ` Sasha Levin
2024-12-11 4:25 ` [stable-kernel][5.15.y][PATCH 5/5] serial: sc16is7xx: change EFR lock to operate on each channels Hui Wang
2024-12-11 16:32 ` Sasha Levin
2024-12-12 13:44 ` Greg KH [this message]
2024-12-12 14:00 ` [stable-kernel][5.15.y][PATCH 0/5] Fix a regression on sc16is7xx Hui Wang
2024-12-16 18:36 ` Hugo Villeneuve
2024-12-17 2:45 ` Hui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024121241-civil-diligence-dc09@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=hvilleneuve@dimonoff.com \
--cc=patches@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.