From: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
To: helgaas@kernel.org
Cc: bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, namcao@linutronix.de, ngn@ngn.tf,
scott@spiteful.org, trintaeoitogc@gmail.com
Subject: Re: [RESEND PATCH] PCI: remove already resolved TODO
Date: Fri, 13 Dec 2024 12:17:10 -0300 [thread overview]
Message-ID: <20241213151710.805485-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <20241212163629.GA3346193@bhelgaas>
Bjorn Helgaas <helgaas@kernel.org> wrote:
> I see a test and call for .get_power() and .set_power(), but no actual
> implementations, so I think they can be removed as well, can't they?
> If so, I'll wait for that removal before applying this patch.
You are right. Both only have a check if exist the {g|s}et_power(), then this
is called.
But, as you already said, seems that really don't have a implementations for
both. So, I can work on remove this fields an tests this.
In the cpci_hotplug.h we can crate a `flags` field in `cpci_hp_controller_ops`
struct, in addition of remove the {g|s}et_power(). In the cpci_hotplug_core.c
that the cpci_hp_controller_ops struct is in use, maybe we can create a #define
SLOT_ENABLED 0x00000001, and we can do `ops->flags |= ENABLED_SLOT` when we
need enable the slot in the enable_slot() function and `ops->flags &=
~ENABLE_SLOT` in the disable_slot() function. In the get_power() function we
only need return `ops->flags & SLOT_ENABLED`.
what do you think?
> In
> https://lore.kernel.org/r/20241014131917.324667-1-trintaeoitogc@gmail.com,
> you capitalized your names. What's your preference? I'd like to use
> your name correctly and consistently.
I make mistake, sorry for this. In the next commit I will send with my name
capitalized.
next prev parent reply other threads:[~2024-12-13 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 11:02 [RESEND PATCH] PCI: remove already resolved TODO guilherme giacomo simoes
2024-12-12 16:36 ` Bjorn Helgaas
2024-12-13 15:17 ` Guilherme Giacomo Simoes [this message]
2024-12-13 16:56 ` Bjorn Helgaas
2024-12-13 18:06 ` Guilherme Giacomo Simoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213151710.805485-1-trintaeoitogc@gmail.com \
--to=trintaeoitogc@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=ngn@ngn.tf \
--cc=scott@spiteful.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.