From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1] tools/net/ynl: fix sub-message key lookup for nested attributes
Date: Fri, 13 Dec 2024 17:47:05 -0800 [thread overview]
Message-ID: <20241213174705.39a24574@kernel.org> (raw)
In-Reply-To: <20241213130711.40267-1-donald.hunter@gmail.com>
On Fri, 13 Dec 2024 13:07:11 +0000 Donald Hunter wrote:
> Use the correct attribute space for sub-message key lookup in nested
> attributes when adding attributes. This fixes rt_link where the "kind"
> key and "data" sub-message are nested attributes in "linkinfo".
>
> For example:
>
> ./tools/net/ynl/cli.py \
> --create \
> --spec Documentation/netlink/specs/rt_link.yaml \
> --do newlink \
> --json '{"link": 99,
> "linkinfo": { "kind": "vlan", "data": {"id": 4 } }
> }'
Let's take it as a fix into net (no need to repost):
Fixes: ab463c4342d1 ("tools/net/ynl: Add support for encoding sub-messages")
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2024-12-14 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 13:07 [PATCH net-next v1] tools/net/ynl: fix sub-message key lookup for nested attributes Donald Hunter
2024-12-14 1:47 ` Jakub Kicinski [this message]
2024-12-15 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213174705.39a24574@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.