From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <jstultz@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Bert Karwatzki <spasswolf@web.de>,
kernel-team@android.com
Subject: Re: [RFC][PATCH] locking/rtmutex: Make sure we wake anything on the wake_q when we release the lock->wait_lock
Date: Sat, 14 Dec 2024 19:46:31 +0100 [thread overview]
Message-ID: <20241214184631.GD10560@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CANDhNCo0W6cYhVQm7TQso=E9evhYy2oxSLnVz-KxbOdfomZFgQ@mail.gmail.com>
On Fri, Dec 13, 2024 at 06:39:45PM -0800, John Stultz wrote:
> On Fri, Dec 13, 2024 at 4:46 AM Peter Zijlstra <peterz@infradead.org> wrote:
> I think all of the calls are tied to the unlock (the one you quoted
> earlier was removed with 82f9cc094975240), so would something like a
> special unlock be reasonable:
> raw_spin_unlock_irq_and_wake(&lock->wait_lock, wake_q)
> ?
Ha, that's what I started with :-) Then found there's two irq_restore()
variants for raisins and it all turned to shit.
next prev parent reply other threads:[~2024-12-14 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 22:21 [RFC][PATCH] locking/rtmutex: Make sure we wake anything on the wake_q when we release the lock->wait_lock John Stultz
2024-12-13 12:46 ` Peter Zijlstra
2024-12-13 13:59 ` Peter Zijlstra
2024-12-14 2:39 ` John Stultz
2024-12-14 18:46 ` Peter Zijlstra [this message]
2024-12-17 4:07 ` [RFC][PATCH] sched/wake_q: Add helper to call wake_up_q after unlock with preemption disabled John Stultz
2024-12-24 18:53 ` [tip: locking/core] " tip-bot2 for John Stultz
2024-12-24 9:46 ` [tip: locking/urgent] locking/rtmutex: Make sure we wake anything on the wake_q when we release the lock->wait_lock tip-bot2 for John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241214184631.GD10560@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=jstultz@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=spasswolf@web.de \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.