From: kernel test robot <lkp@intel.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: oe-kbuild-all@lists.linux.dev, Mark Brown <broonie@kernel.org>
Subject: [broonie-misc:asoc-6.14 13/25] drivers/firmware/cirrus/test/cs_dsp_mock_bin.c:153: warning: Function parameter or struct member 'alg_id' not described in 'cs_dsp_mock_bin_add_patch'
Date: Sat, 14 Dec 2024 22:56:27 +0800 [thread overview]
Message-ID: <202412142205.HHHcousT-lkp@intel.com> (raw)
Hi Richard,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git asoc-6.14
head: 5ce3beed07b8145aff61f2cb41f1868f6221271f
commit: dd0b6b1f29b92202d03a6d2dd7d65ecead27941a [13/25] firmware: cs_dsp: Add KUnit testing of bin file download
config: arc-randconfig-001-20241214 (https://download.01.org/0day-ci/archive/20241214/202412142205.HHHcousT-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241214/202412142205.HHHcousT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412142205.HHHcousT-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/firmware/cirrus/test/cs_dsp_mock_bin.c:67: warning: Function parameter or struct member 'alg_id' not described in 'cs_dsp_mock_bin_add_raw_block'
>> drivers/firmware/cirrus/test/cs_dsp_mock_bin.c:67: warning: Excess function parameter 'alg_ig' description in 'cs_dsp_mock_bin_add_raw_block'
>> drivers/firmware/cirrus/test/cs_dsp_mock_bin.c:153: warning: Function parameter or struct member 'alg_id' not described in 'cs_dsp_mock_bin_add_patch'
>> drivers/firmware/cirrus/test/cs_dsp_mock_bin.c:153: warning: Excess function parameter 'alg_ig' description in 'cs_dsp_mock_bin_add_patch'
vim +153 drivers/firmware/cirrus/test/cs_dsp_mock_bin.c
7c052c6615297ff Richard Fitzgerald 2024-12-12 51
7c052c6615297ff Richard Fitzgerald 2024-12-12 52 /**
7c052c6615297ff Richard Fitzgerald 2024-12-12 53 * cs_dsp_mock_bin_add_raw_block() - Add a data block to the bin file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 54 *
7c052c6615297ff Richard Fitzgerald 2024-12-12 55 * @builder: Pointer to struct cs_dsp_mock_bin_builder.
7c052c6615297ff Richard Fitzgerald 2024-12-12 56 * @alg_ig: Algorithm ID.
7c052c6615297ff Richard Fitzgerald 2024-12-12 57 * @alg_ver: Algorithm version.
7c052c6615297ff Richard Fitzgerald 2024-12-12 58 * @type: Type of the block.
7c052c6615297ff Richard Fitzgerald 2024-12-12 59 * @offset: Offset.
7c052c6615297ff Richard Fitzgerald 2024-12-12 60 * @payload_data: Pointer to buffer containing the payload data.
7c052c6615297ff Richard Fitzgerald 2024-12-12 61 * @payload_len_bytes: Length of payload data in bytes.
7c052c6615297ff Richard Fitzgerald 2024-12-12 62 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 63 void cs_dsp_mock_bin_add_raw_block(struct cs_dsp_mock_bin_builder *builder,
7c052c6615297ff Richard Fitzgerald 2024-12-12 64 unsigned int alg_id, unsigned int alg_ver,
7c052c6615297ff Richard Fitzgerald 2024-12-12 65 int type, unsigned int offset,
7c052c6615297ff Richard Fitzgerald 2024-12-12 66 const void *payload_data, size_t payload_len_bytes)
7c052c6615297ff Richard Fitzgerald 2024-12-12 @67 {
7c052c6615297ff Richard Fitzgerald 2024-12-12 68 struct wmfw_coeff_item *item;
7c052c6615297ff Richard Fitzgerald 2024-12-12 69 size_t bytes_needed = struct_size_t(struct wmfw_coeff_item, data, payload_len_bytes);
7c052c6615297ff Richard Fitzgerald 2024-12-12 70
7c052c6615297ff Richard Fitzgerald 2024-12-12 71 KUNIT_ASSERT_TRUE(builder->test_priv->test,
7c052c6615297ff Richard Fitzgerald 2024-12-12 72 (builder->write_p + bytes_needed) <
7c052c6615297ff Richard Fitzgerald 2024-12-12 73 (builder->buf + CS_DSP_MOCK_BIN_BUF_SIZE));
7c052c6615297ff Richard Fitzgerald 2024-12-12 74
7c052c6615297ff Richard Fitzgerald 2024-12-12 75 item = builder->write_p;
7c052c6615297ff Richard Fitzgerald 2024-12-12 76
7c052c6615297ff Richard Fitzgerald 2024-12-12 77 item->offset = cpu_to_le16(offset);
7c052c6615297ff Richard Fitzgerald 2024-12-12 78 item->type = cpu_to_le16(type);
7c052c6615297ff Richard Fitzgerald 2024-12-12 79 item->id = cpu_to_le32(alg_id);
7c052c6615297ff Richard Fitzgerald 2024-12-12 80 item->ver = cpu_to_le32(alg_ver << 8);
7c052c6615297ff Richard Fitzgerald 2024-12-12 81 item->len = cpu_to_le32(payload_len_bytes);
7c052c6615297ff Richard Fitzgerald 2024-12-12 82
7c052c6615297ff Richard Fitzgerald 2024-12-12 83 if (payload_len_bytes)
7c052c6615297ff Richard Fitzgerald 2024-12-12 84 memcpy(item->data, payload_data, payload_len_bytes);
7c052c6615297ff Richard Fitzgerald 2024-12-12 85
7c052c6615297ff Richard Fitzgerald 2024-12-12 86 builder->write_p += bytes_needed;
7c052c6615297ff Richard Fitzgerald 2024-12-12 87 builder->bytes_used += bytes_needed;
7c052c6615297ff Richard Fitzgerald 2024-12-12 88 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 89 EXPORT_SYMBOL_NS_GPL(cs_dsp_mock_bin_add_raw_block, "FW_CS_DSP_KUNIT_TEST_UTILS");
7c052c6615297ff Richard Fitzgerald 2024-12-12 90
7c052c6615297ff Richard Fitzgerald 2024-12-12 91 static void cs_dsp_mock_bin_add_name_or_info(struct cs_dsp_mock_bin_builder *builder,
7c052c6615297ff Richard Fitzgerald 2024-12-12 92 const char *info, int type)
7c052c6615297ff Richard Fitzgerald 2024-12-12 93 {
7c052c6615297ff Richard Fitzgerald 2024-12-12 94 size_t info_len = strlen(info);
7c052c6615297ff Richard Fitzgerald 2024-12-12 95 char *tmp = NULL;
7c052c6615297ff Richard Fitzgerald 2024-12-12 96
7c052c6615297ff Richard Fitzgerald 2024-12-12 97 if (info_len % 4) {
7c052c6615297ff Richard Fitzgerald 2024-12-12 98 /* Create a padded string with length a multiple of 4 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 99 info_len = round_up(info_len, 4);
7c052c6615297ff Richard Fitzgerald 2024-12-12 100 tmp = kunit_kzalloc(builder->test_priv->test, info_len, GFP_KERNEL);
7c052c6615297ff Richard Fitzgerald 2024-12-12 101 KUNIT_ASSERT_NOT_ERR_OR_NULL(builder->test_priv->test, tmp);
7c052c6615297ff Richard Fitzgerald 2024-12-12 102 memcpy(tmp, info, info_len);
7c052c6615297ff Richard Fitzgerald 2024-12-12 103 info = tmp;
7c052c6615297ff Richard Fitzgerald 2024-12-12 104 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 105
7c052c6615297ff Richard Fitzgerald 2024-12-12 106 cs_dsp_mock_bin_add_raw_block(builder, 0, 0, WMFW_INFO_TEXT, 0, info, info_len);
7c052c6615297ff Richard Fitzgerald 2024-12-12 107 kunit_kfree(builder->test_priv->test, tmp);
7c052c6615297ff Richard Fitzgerald 2024-12-12 108 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 109
7c052c6615297ff Richard Fitzgerald 2024-12-12 110 /**
7c052c6615297ff Richard Fitzgerald 2024-12-12 111 * cs_dsp_mock_bin_add_info() - Add an info block to the bin file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 112 *
7c052c6615297ff Richard Fitzgerald 2024-12-12 113 * @builder: Pointer to struct cs_dsp_mock_bin_builder.
7c052c6615297ff Richard Fitzgerald 2024-12-12 114 * @info: Pointer to info string to be copied into the file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 115 *
7c052c6615297ff Richard Fitzgerald 2024-12-12 116 * The string will be padded to a length that is a multiple of 4 bytes.
7c052c6615297ff Richard Fitzgerald 2024-12-12 117 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 118 void cs_dsp_mock_bin_add_info(struct cs_dsp_mock_bin_builder *builder,
7c052c6615297ff Richard Fitzgerald 2024-12-12 119 const char *info)
7c052c6615297ff Richard Fitzgerald 2024-12-12 120 {
7c052c6615297ff Richard Fitzgerald 2024-12-12 121 cs_dsp_mock_bin_add_name_or_info(builder, info, WMFW_INFO_TEXT);
7c052c6615297ff Richard Fitzgerald 2024-12-12 122 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 123 EXPORT_SYMBOL_NS_GPL(cs_dsp_mock_bin_add_info, "FW_CS_DSP_KUNIT_TEST_UTILS");
7c052c6615297ff Richard Fitzgerald 2024-12-12 124
7c052c6615297ff Richard Fitzgerald 2024-12-12 125 /**
7c052c6615297ff Richard Fitzgerald 2024-12-12 126 * cs_dsp_mock_bin_add_name() - Add a name block to the bin file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 127 *
7c052c6615297ff Richard Fitzgerald 2024-12-12 128 * @builder: Pointer to struct cs_dsp_mock_bin_builder.
7c052c6615297ff Richard Fitzgerald 2024-12-12 129 * @name: Pointer to name string to be copied into the file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 130 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 131 void cs_dsp_mock_bin_add_name(struct cs_dsp_mock_bin_builder *builder,
7c052c6615297ff Richard Fitzgerald 2024-12-12 132 const char *name)
7c052c6615297ff Richard Fitzgerald 2024-12-12 133 {
7c052c6615297ff Richard Fitzgerald 2024-12-12 134 cs_dsp_mock_bin_add_name_or_info(builder, name, WMFW_NAME_TEXT);
7c052c6615297ff Richard Fitzgerald 2024-12-12 135 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 136 EXPORT_SYMBOL_NS_GPL(cs_dsp_mock_bin_add_name, "FW_CS_DSP_KUNIT_TEST_UTILS");
7c052c6615297ff Richard Fitzgerald 2024-12-12 137
7c052c6615297ff Richard Fitzgerald 2024-12-12 138 /**
7c052c6615297ff Richard Fitzgerald 2024-12-12 139 * cs_dsp_mock_bin_add_patch() - Add a patch data block to the bin file.
7c052c6615297ff Richard Fitzgerald 2024-12-12 140 *
7c052c6615297ff Richard Fitzgerald 2024-12-12 141 * @builder: Pointer to struct cs_dsp_mock_bin_builder.
7c052c6615297ff Richard Fitzgerald 2024-12-12 142 * @alg_ig: Algorithm ID for the patch.
7c052c6615297ff Richard Fitzgerald 2024-12-12 143 * @alg_ver: Algorithm version for the patch.
7c052c6615297ff Richard Fitzgerald 2024-12-12 144 * @mem_region: Memory region for the patch.
7c052c6615297ff Richard Fitzgerald 2024-12-12 145 * @reg_addr_offset: Offset to start of data in register addresses.
7c052c6615297ff Richard Fitzgerald 2024-12-12 146 * @payload_data: Pointer to buffer containing the payload data.
7c052c6615297ff Richard Fitzgerald 2024-12-12 147 * @payload_len_bytes: Length of payload data in bytes.
7c052c6615297ff Richard Fitzgerald 2024-12-12 148 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 149 void cs_dsp_mock_bin_add_patch(struct cs_dsp_mock_bin_builder *builder,
7c052c6615297ff Richard Fitzgerald 2024-12-12 150 unsigned int alg_id, unsigned int alg_ver,
7c052c6615297ff Richard Fitzgerald 2024-12-12 151 int mem_region, unsigned int reg_addr_offset,
7c052c6615297ff Richard Fitzgerald 2024-12-12 152 const void *payload_data, size_t payload_len_bytes)
7c052c6615297ff Richard Fitzgerald 2024-12-12 @153 {
7c052c6615297ff Richard Fitzgerald 2024-12-12 154 /* Payload length must be a multiple of 4 */
7c052c6615297ff Richard Fitzgerald 2024-12-12 155 KUNIT_ASSERT_EQ(builder->test_priv->test, payload_len_bytes % 4, 0);
7c052c6615297ff Richard Fitzgerald 2024-12-12 156
7c052c6615297ff Richard Fitzgerald 2024-12-12 157 cs_dsp_mock_bin_add_raw_block(builder, alg_id, alg_ver,
7c052c6615297ff Richard Fitzgerald 2024-12-12 158 mem_region, reg_addr_offset,
7c052c6615297ff Richard Fitzgerald 2024-12-12 159 payload_data, payload_len_bytes);
7c052c6615297ff Richard Fitzgerald 2024-12-12 160 }
7c052c6615297ff Richard Fitzgerald 2024-12-12 161 EXPORT_SYMBOL_NS_GPL(cs_dsp_mock_bin_add_patch, "FW_CS_DSP_KUNIT_TEST_UTILS");
7c052c6615297ff Richard Fitzgerald 2024-12-12 162
:::::: The code at line 153 was first introduced by commit
:::::: 7c052c6615297ff32032105130cd5f02059f7ae4 firmware: cs_dsp: Add mock bin file generator for KUnit testing
:::::: TO: Richard Fitzgerald <rf@opensource.cirrus.com>
:::::: CC: Mark Brown <broonie@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-12-14 14:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412142205.HHHcousT-lkp@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.