Re: [PATCH] arm: imx: Remove arch_env_get_location to fix env lockdown

[Peng Fan <peng.fan@oss.nxp.com>]

s/imx/layerscape/

On Thu, Nov 07, 2024 at 01:50:44PM +0100, Abdelrahman Ibrahem wrote:
>This patch resolves an issue encountered with Layerscape SoCs, where
>attempts to restrict write access to environment variables to enforce
>secureboot are ineffective when using the CONFIG_ENV_IS_NOWHERE
>configuration in combination with CONFIG_ENV_IS_IN_xxx.
>
>Signed-off-by: Abdelrahman Ibrahem <mail@aibrahem.com>
>---
>
> arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 41 -------------------------
> 1 file changed, 41 deletions(-)
>
>diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>index d2d3e346a3..7dd5f429bf 100644
>--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
>@@ -819,47 +819,6 @@ int mmc_get_env_dev(void)
> }
> #endif
> 
>-enum env_location arch_env_get_location(enum env_operation op, int prio)
>-{

This looks wrong to me. Drop the arch_env_get_location would break
other cases.

Thanks,
Peng