From: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
To: buildroot@buildroot.org
Cc: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>
Subject: [Buildroot] [PATCH] package/quickjs: fix typo in prefix
Date: Mon, 16 Dec 2024 22:30:52 +0100 [thread overview]
Message-ID: <20241216-fix_quickjs_prefix-v1-1-88ed52e67b76@bootlin.com> (raw)
The quickjs Makefile expects the variable PREFIX to be set [1] but
prefix is set instead.
Without this parameter quickjs is installed to /usr/local by default [2]
instead of /usr as requested.
This commit fixed this error.
[1]: https://github.com/bellard/quickjs/blob/master/Makefile#L383
[2]: https://github.com/bellard/quickjs/blob/master/Makefile#L43
Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
---
package/quickjs/quickjs.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/quickjs/quickjs.mk b/package/quickjs/quickjs.mk
index e745923b87bff3cdeb2f872264be5e65466020cf..2bd9da1392cb853e57492253c6202a65187fb81e 100644
--- a/package/quickjs/quickjs.mk
+++ b/package/quickjs/quickjs.mk
@@ -29,7 +29,7 @@ define QUICKJS_INSTALL_STAGING_CMDS
EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
DESTDIR=$(STAGING_DIR) \
STRIP=/bin/true \
- prefix=/usr \
+ PREFIX=/usr \
install
endef
@@ -39,7 +39,7 @@ define QUICKJS_INSTALL_TARGET_CMDS
EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
DESTDIR=$(TARGET_DIR) \
STRIP=/bin/true \
- prefix=/usr \
+ PREFIX=/usr \
install
endef
---
base-commit: ed9da089449c53519be02204f97c3452abba5cc3
change-id: 20241211-fix_quickjs_prefix-28a1837f0d65
Best regards,
--
Thomas Bonnefille <thomas.bonnefille@bootlin.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2024-12-16 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 21:30 Thomas Bonnefille [this message]
2024-12-16 22:01 ` [Buildroot] [PATCH] package/quickjs: fix typo in prefix Julien Olivain
2024-12-16 22:03 ` Thomas Petazzoni via buildroot
2024-12-29 20:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216-fix_quickjs_prefix-v1-1-88ed52e67b76@bootlin.com \
--to=thomas.bonnefille@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.