All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Stone <leocstone@gmail.com>
To: syzbot+4eb7a741b3216020043a@syzkaller.appspotmail.com
Cc: Leo Stone <leocstone@gmail.com>,
	jmorris@namei.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org, mortonm@chromium.org,
	paul@paul-moore.com, serge@hallyn.com,
	syzkaller-bugs@googlegroups.com
Subject: [PATCH] lsm: check size of writes
Date: Sun, 15 Dec 2024 19:02:11 -0800	[thread overview]
Message-ID: <20241216030213.246804-2-leocstone@gmail.com> (raw)
In-Reply-To: <675f513a.050a0220.37aaf.0106.GAE@google.com>

syzbot attempts to write a buffer with a large size to a sysfs entry
with writes handled by safesetid_gid_file_write(), triggering a warning
in kmalloc.

Check the size specified for write buffers before allocating.

Reported-by: syzbot+4eb7a741b3216020043a@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=4eb7a741b3216020043a
Signed-off-by: Leo Stone <leocstone@gmail.com>
---
 security/safesetid/securityfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/safesetid/securityfs.c b/security/safesetid/securityfs.c
index 25310468bcdd..5eba4c7f8d9e 100644
--- a/security/safesetid/securityfs.c
+++ b/security/safesetid/securityfs.c
@@ -254,7 +254,7 @@ static ssize_t safesetid_gid_file_write(struct file *file,
 	if (!file_ns_capable(file, &init_user_ns, CAP_MAC_ADMIN))
 		return -EPERM;
 
-	if (*ppos != 0)
+	if (*ppos != 0 || len >= KMALLOC_MAX_SIZE)
 		return -EINVAL;
 
 	return handle_policy_update(file, buf, len, GID);
-- 
2.43.0


  reply	other threads:[~2024-12-16  3:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15 21:59 [syzbot] [lsm?] WARNING in handle_policy_update syzbot
2024-12-16  3:02 ` Leo Stone [this message]
2024-12-16  9:58   ` [PATCH] lsm: check size of writes Tetsuo Handa
2024-12-16 22:59     ` Paul Moore
2024-12-17 18:26 ` [PATCH v2] " Leo Stone
2024-12-18 21:51   ` Paul Moore
2024-12-21 10:00     ` Tetsuo Handa
2024-12-21 13:40       ` Tetsuo Handa
2024-12-23  5:32         ` Kees Cook
2025-01-05  4:04           ` Paul Moore
2025-01-07  0:09             ` Kees Cook
2025-01-08 21:17               ` Paul Moore
2025-01-05  3:51       ` Paul Moore
2025-01-05  3:49     ` Paul Moore
2025-01-24 19:24       ` Micah Morton
2025-01-24 19:42         ` Paul Moore
2025-01-27 16:05           ` Micah Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241216030213.246804-2-leocstone@gmail.com \
    --to=leocstone@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mortonm@chromium.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=syzbot+4eb7a741b3216020043a@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.