From: Arnd Bergmann <arnd@kernel.org>
To: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Anand Jain <anand.jain@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Qu Wenruo <wqu@suse.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Boris Burkov <boris@bur.io>, Naohiro Aota <naohiro.aota@wdc.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: avoid opencoded 64-bit div/mod operation
Date: Mon, 16 Dec 2024 09:32:37 +0100 [thread overview]
Message-ID: <20241216083248.1816638-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Dividing 64-bit numbers causes a link failure on 32-bit builds:
arm-linux-gnueabi-ld: fs/btrfs/sysfs.o: in function `btrfs_read_policy_store':
sysfs.c:(.text+0x3ce0): undefined reference to `__aeabi_ldivmod'
Use an explicit call to div_u64_rem() here to work around this. It would
be possible to optimize this further, but this is not a performance
critical operation.
Fixes: 185fa5c7ac5a ("btrfs: introduce RAID1 round-robin read balancing")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/btrfs/sysfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 50bc4b6cb821..67bc8fa4d6ab 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1433,7 +1433,9 @@ static ssize_t btrfs_read_policy_store(struct kobject *kobj,
#ifdef CONFIG_BTRFS_EXPERIMENTAL
if (index == BTRFS_READ_POLICY_RR) {
if (value != -1) {
- if ((value % fs_devices->fs_info->sectorsize) != 0) {
+ u32 rem;
+ div_u64_rem(value, fs_devices->fs_info->sectorsize, &rem);
+ if (rem) {
btrfs_err(fs_devices->fs_info,
"read_policy: min_contiguous_read %lld should be multiples of the sectorsize %u",
value, fs_devices->fs_info->sectorsize);
--
2.39.5
next reply other threads:[~2024-12-16 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 8:32 Arnd Bergmann [this message]
2024-12-16 8:37 ` [PATCH] btrfs: avoid opencoded 64-bit div/mod operation Qu Wenruo
2024-12-16 9:22 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216083248.1816638-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=anand.jain@oracle.com \
--cc=arnd@arndb.de \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.