From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Jens Axboe <axboe@kernel.dk>, Boris Burkov <boris@bur.io>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<linux-block@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v3 9/9] driver core: Introduce device_iter_t for device iterating APIs
Date: Mon, 16 Dec 2024 15:33:41 +0000 [thread overview]
Message-ID: <20241216153341.00001867@huawei.com> (raw)
In-Reply-To: <20241212-class_fix-v3-9-04e20c4f0971@quicinc.com>
On Thu, 12 Dec 2024 21:38:45 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> There are several for_each APIs which has parameter with type below:
> int (*fn)(struct device *dev, void *data)
> They iterate over various device lists and call @fn() for each device
> with caller provided data @*data, and they usually need to modify @*data.
>
> Give the type an dedicated typedef with advantages shown below:
> typedef int (*device_iter_t)(struct device *dev, void *data)
>
> - Shorter API declarations and definitions
> - Prevent further for_each APIs from using bad parameter type
>
> So introduce device_iter_t and apply it to various existing APIs below:
> bus_for_each_dev()
> (class|driver)_for_each_device()
> device_for_each_child(_reverse|_reverse_from)().
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
I'd normally argue this wasn't worth the effort, but given you tidied
up one inconsistent case in this series, fair enough as far as I'm concerned.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
prev parent reply other threads:[~2024-12-16 15:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 13:38 [PATCH v3 0/9] driver core: class: Fix bug and code improvements for class APIs Zijun Hu
2024-12-12 13:38 ` [PATCH v3 1/9] driver core: class: Fix wild pointer dereferences in API class_dev_iter_next() Zijun Hu
2024-12-16 15:36 ` Jonathan Cameron
2024-12-17 14:09 ` Zijun Hu
2024-12-12 13:38 ` [PATCH v3 2/9] blk-cgroup: Fix class @block_class's subsystem refcount leakage Zijun Hu
2024-12-17 10:53 ` Michal Koutný
2024-12-12 13:38 ` [PATCH v3 3/9] driver core: bus: Move true expression out of if condition in API bus_find_device() Zijun Hu
2024-12-16 15:14 ` Jonathan Cameron
2024-12-12 13:38 ` [PATCH v3 4/9] driver core: Move true expression out of if condition in API driver_find_device() Zijun Hu
2024-12-16 15:18 ` Jonathan Cameron
2024-12-16 18:01 ` Fan Ni
2024-12-17 14:13 ` Zijun Hu
2024-12-12 13:38 ` [PATCH v3 5/9] driver core: Move true expression out of if condition in API device_find_child() Zijun Hu
2024-12-16 15:19 ` Jonathan Cameron
2024-12-16 18:02 ` Fan Ni
2024-12-12 13:38 ` [PATCH v3 6/9] driver core: Rename declaration parameter name for API device_find_child() cluster Zijun Hu
2024-12-16 15:21 ` Jonathan Cameron
2024-12-16 18:02 ` Fan Ni
2024-12-12 13:38 ` [PATCH v3 7/9] driver core: Correct parameter check for API device_for_each_child_reverse_from() Zijun Hu
2024-12-16 15:23 ` Jonathan Cameron
2024-12-17 14:18 ` Zijun Hu
2024-12-12 13:38 ` [PATCH v3 8/9] driver core: Correct API device_for_each_child_reverse_from() prototype Zijun Hu
2024-12-16 15:30 ` Jonathan Cameron
2024-12-12 13:38 ` [PATCH v3 9/9] driver core: Introduce device_iter_t for device iterating APIs Zijun Hu
2024-12-16 15:33 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216153341.00001867@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=axboe@kernel.dk \
--cc=boris@bur.io \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.