From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: jes@trained-monkey.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-hippi@sunsite.dk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev
Date: Mon, 16 Dec 2024 16:12:06 +0000 [thread overview]
Message-ID: <20241216161206.GF780307@kernel.org> (raw)
In-Reply-To: <20241215022618.181756-1-linux@treblig.org>
On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> hippi_neigh_setup_dev() has been unused since
> commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")
>
> Remove it.
>
> (I'm a little suspicious it's the only setup call removed
> by that previous commit?)
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi David,
There is a dangling comment referring to hippi_neigh_setup_dev
in hippi_setup().
/*
* HIPPI doesn't support broadcast+multicast and we only use
* static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
*/
Could you fix that up too?
pw-bot: changes-requested
next prev parent reply other threads:[~2024-12-16 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 2:26 [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev linux
2024-12-15 2:28 ` Dr. David Alan Gilbert
2024-12-16 16:14 ` Simon Horman
2024-12-16 16:56 ` Dr. David Alan Gilbert
2024-12-16 16:12 ` Simon Horman [this message]
2024-12-16 16:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216161206.GF780307@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jes@trained-monkey.org \
--cc=kuba@kernel.org \
--cc=linux-hippi@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.