From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: [PATCH 1/2] block: Optimize blk_mq_submit_bio() for the cache hit scenario
Date: Mon, 16 Dec 2024 12:19:00 -0800 [thread overview]
Message-ID: <20241216201901.2670237-2-bvanassche@acm.org> (raw)
In-Reply-To: <20241216201901.2670237-1-bvanassche@acm.org>
Help the CPU branch predictor in case of a cache hit by handling the cache
hit scenario first.
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
block/blk-mq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 7ee21346a41e..8d2aab4d9ba9 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3102,12 +3102,12 @@ void blk_mq_submit_bio(struct bio *bio)
goto queue_exit;
new_request:
- if (!rq) {
+ if (rq) {
+ blk_mq_use_cached_rq(rq, plug, bio);
+ } else {
rq = blk_mq_get_new_requests(q, plug, bio, nr_segs);
if (unlikely(!rq))
goto queue_exit;
- } else {
- blk_mq_use_cached_rq(rq, plug, bio);
}
trace_block_getrq(bio);
next prev parent reply other threads:[~2024-12-16 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 20:18 [PATCH 0/2] Move blk_mq_submit_bio() error handling Bart Van Assche
2024-12-16 20:19 ` Bart Van Assche [this message]
2024-12-17 4:16 ` [PATCH 1/2] block: Optimize blk_mq_submit_bio() for the cache hit scenario Christoph Hellwig
2024-12-17 19:22 ` Bart Van Assche
2024-12-17 21:15 ` Jens Axboe
2024-12-18 6:59 ` Christoph Hellwig
2024-12-18 18:22 ` Bart Van Assche
2024-12-16 20:19 ` [PATCH 2/2] blk-mq: Move more error handling into blk_mq_submit_bio() Bart Van Assche
2024-12-17 4:18 ` Christoph Hellwig
2024-12-17 21:06 ` Bart Van Assche
2024-12-18 7:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216201901.2670237-2-bvanassche@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.