Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Mon, 16 Dec 2024 21:56:04 +0100
"Thomas Bonnefille" <thomas.bonnefille@bootlin.com> wrote:

> > But more importantly: https://github.com/pseiderer/libsha1/ isn't
> > "upstream". Upstream for this package is
> > https://github.com/dottedmag/libsha1. So we're interested in seeing
> > the change having been submitted or accepted by the real upstream, not
> > just a commit in some "random" Github repository (even though Peter
> > Seiderer is a well known Buildroot contributor!)  
> 
> Ok so a link to the pull-request is probably better here according to BR
> documentation.
> (https://github.com/dottedmag/libsha1/pull/1)

Yes, that's the reference we want indeed.

> However, in this case the PR may not be merged soon given the date of
> the last commit applied to the upstream package.

Gah, indeed. I tried quickly to find another "upstream", but there
doesn't seem to be an obvious upstream alternative. This package is
used by xwayland and xserver_xorg-server as a minimal alternative to a
full-blown crypto library like OpenSSL or libgcrypt.

I think for now, your change with Upstream:
https://github.com/dottedmag/libsha1/pull/1 is going to be good enough.
We can always separately decide if we want to drop this package
entirely.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot