From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH 5/6] blk-zoned: Uninline functions that are not in the hot path
Date: Tue, 17 Dec 2024 05:24:07 +0100 [thread overview]
Message-ID: <20241217042407.GE15358@lst.de> (raw)
In-Reply-To: <20241216210244.2687662-6-bvanassche@acm.org>
On Mon, Dec 16, 2024 at 01:02:43PM -0800, Bart Van Assche wrote:
> Apply the convention that is followed elsewhere in the block layer: only
> declare functions inline if these are in the hot path. This patch makes it
> easier to debug the code in blk-zoned.c with trace_printk(). trace_printk()
> only displays the function name correctly for functions that are not
> inlined.
The other convention is to mark them as inline if they are so tiny
that force inlinining is guaranteed to generate smaller code.
disk_need_zone_resources seems a pretty clear case of that, while for
the blk_zone_wplug_bio_io_error the forced inlining is indeed a bit
questionable. I'm still not sure what the sudden urge to change it is?
next prev parent reply other threads:[~2024-12-17 4:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 21:02 [PATCH 0/6] Minor improvements for the zoned block storage code Bart Van Assche
2024-12-16 21:02 ` [PATCH 1/6] blk-zoned: Minimize #include directives Bart Van Assche
2024-12-17 4:18 ` Christoph Hellwig
2024-12-17 15:07 ` Damien Le Moal
2024-12-16 21:02 ` [PATCH 2/6] blk-zoned: Document the locking order Bart Van Assche
2024-12-17 4:21 ` Christoph Hellwig
2024-12-16 21:02 ` [PATCH 3/6] blk-zoned: Document locking assumptions Bart Van Assche
2024-12-17 4:21 ` Christoph Hellwig
2024-12-17 15:07 ` Damien Le Moal
2024-12-16 21:02 ` [PATCH 4/6] blk-zoned: Improve the queue reference count strategy documentation Bart Van Assche
2024-12-17 4:21 ` Christoph Hellwig
2024-12-17 15:07 ` Damien Le Moal
2024-12-16 21:02 ` [PATCH 5/6] blk-zoned: Uninline functions that are not in the hot path Bart Van Assche
2024-12-17 4:24 ` Christoph Hellwig [this message]
2024-12-16 21:02 ` [PATCH 6/6] blk-zoned: Split queue_zone_wplugs_show() Bart Van Assche
2024-12-17 4:24 ` Christoph Hellwig
2024-12-17 15:06 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217042407.GE15358@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.