From: Jakub Kicinski <kuba@kernel.org>
To: saeedm@nvidia.com, tariqt@nvidia.com, gal@nvidia.com
Cc: Yafang Shao <laoar.shao@gmail.com>,
netdev@vger.kernel.org, Tariq Toukan <ttoukan.linux@gmail.com>
Subject: Re: [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via rx_dropped
Date: Tue, 17 Dec 2024 10:45:56 -0800 [thread overview]
Message-ID: <20241217104556.18e4571c@kernel.org> (raw)
In-Reply-To: <20241210022706.6665-1-laoar.shao@gmail.com>
On Tue, 10 Dec 2024 10:27:06 +0800 Yafang Shao wrote:
> We noticed a high number of rx_discards_phy events on certain servers while
> running `ethtool -S`. However, this critical counter is not currently
> included in the standard /proc/net/dev statistics file, making it difficult
> to monitor effectively—especially given the diversity of vendors across a
> large fleet of servers.
>
> Let's report it via the standard rx_dropped metric.
nVidia folks, could you review? Or you're just taking it via your tree
and it will reappear on the list soon? I want to make sure there is no
off-list discussion with the author that leads to the patch being
"lost"...
next prev parent reply other threads:[~2024-12-17 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 2:27 [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via rx_dropped Yafang Shao
2024-12-10 19:49 ` Simon Horman
2024-12-17 18:45 ` Jakub Kicinski [this message]
2024-12-18 6:20 ` Tariq Toukan
2024-12-19 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217104556.18e4571c@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=laoar.shao@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.