From: Jakub Kicinski <kuba@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Kalle Valo <kvalo@kernel.org>,
Manish Chopra <manishc@marvell.com>,
Rahul Verma <rahulv@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Andrew Lunn <andrew+netdev@lunn.ch>,
Shahed Shaikh <shshaikh@marvell.com>,
bridge@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'
Date: Tue, 17 Dec 2024 19:03:59 -0800 [thread overview]
Message-ID: <20241217190359.6958ea4f@kernel.org> (raw)
In-Reply-To: <20241216-sysfs-const-bin_attr-net-v1-5-ec460b91f274@weissschuh.net>
On Mon, 16 Dec 2024 12:30:12 +0100 Thomas Weißschuh wrote:
> - .read = qlcnic_sysfs_read_pci_config,
> - .write = NULL,
> + .read_new = qlcnic_sysfs_read_pci_config,
> + .write_new = NULL,
Please delete the NULL assignment instead.
next prev parent reply other threads:[~2024-12-18 3:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 11:30 [PATCH net-next 0/5] net: constify 'struct bin_attribute' Thomas Weißschuh
2024-12-16 11:30 ` [PATCH net-next 1/5] net: bridge: " Thomas Weißschuh
2024-12-17 10:27 ` Simon Horman
2024-12-17 10:43 ` Nikolay Aleksandrov
2024-12-16 11:30 ` [PATCH net-next 2/5] net: phy: ks8995: " Thomas Weißschuh
2024-12-16 15:40 ` Andrew Lunn
2024-12-16 11:30 ` [PATCH net-next 3/5] wlcore: sysfs: " Thomas Weißschuh
2024-12-16 12:46 ` Kalle Valo
2024-12-18 18:05 ` [net-next,3/5] wifi: " Kalle Valo
2024-12-16 11:30 ` [PATCH net-next 4/5] netxen_nic: " Thomas Weißschuh
2024-12-17 10:28 ` Simon Horman
2024-12-16 11:30 ` [PATCH net-next 5/5] qlcnic: " Thomas Weißschuh
2024-12-17 10:28 ` Simon Horman
2024-12-18 3:03 ` Jakub Kicinski [this message]
2024-12-18 3:10 ` [PATCH net-next 0/5] net: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217190359.6958ea4f@kernel.org \
--to=kuba@kernel.org \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@weissschuh.net \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rahulv@marvell.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=shshaikh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.