From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5291E5708; Tue, 17 Dec 2024 12:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734437404; cv=none; b=WVcfBgGgmNjYYu7DQRwMa/GWKqAogxnl3lkQESooQ7O3F5sc16+Kaenl9R+RoRpzYC5zKpviX5WDYxcwVp7ctIc7D60va0U87yylvNCr3ZldErBNuU0dgkMaL6sIvblps6gvYB17xzCETTWoxdKLeS4akumDTdSbYuuts+hQKMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734437404; c=relaxed/simple; bh=gac8ql6ts3lihvjphPVIhS+Eq+RhAv3kl8wQtvQ4ZdU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YXOd6RLPvoQnKXc0VqFbVpgQEb02FU6mO4jDuS6PR7MXgtwyJwPW+SID7sdipgH5Sfchl8OAmuzTzLK+f4aossAtaGB0vlv4PGee2MaOhEX9D5VOCt8QR4FXQQD6c+MBA3fCeIdFIT5DuFk7WwUwOosBDOGy3E4YTRkK1xPXdQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KR2MrwCN; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KR2MrwCN" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2156e078563so38966675ad.2; Tue, 17 Dec 2024 04:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734437402; x=1735042202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gk0oaVX4f1jnLyQuTOGkGWyylI3KWC0+6v2HjUrWfmw=; b=KR2MrwCNrA+5DELt3AAiA1Moua4cQCVnKu17Ct7YEeNvdN6slLtPozhrkR9CV4zAFY Im9qSLEh2z3UDNDbBa80agWM2hYxFlNgLCVsoOsbfYXtNZklvTkKextxM2wz82+e85Gq fz2NRhCC+7jkAn0Kal0ZM2m2BxUhEIZWxTrdQ5I0Tr/hH0XvRNzoJFaxXOgB3CkeYcJk Mq3dhPdCsVlDUQtrwdanJIySWf1zRZ2T/4NIz0QIcxXAp4VNmuFQM4WnTJDY+Q2rGNp0 Y14Po+BwB5gDsCfJSwFIOQS1Ztpfr5aIDWYtafIDGwbG7zn8Iz48V8VHZsB8YvL6Urgu FCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734437402; x=1735042202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gk0oaVX4f1jnLyQuTOGkGWyylI3KWC0+6v2HjUrWfmw=; b=maBSLg72yF8tQEw38OtpGbQGvz3fdFu5ya3yiDNn2BzYpaDO0oC8MwNzjKy/XCQhgr Ic1kMnnJRDz8AyKWeFG0Gx6q5nCE2dqoIwsoLYdikQ9XOcD9PZfIu3wWSe02ZE8Detpg Jszdf5oUXHcG50qdpuecQFpk12vrN7Xg17d5av3UL4mAbPQT5EX+38UJfVwiJV4z7bWz BOf1rD9r6i/PCbTJcckDlL5nOMV7YSysBsDzuL5t7jo5A8fHG1l2NfX5y5TEQ8Zmp9X3 c5TjUh1EyhE7mOlcQidpIKg58WUc3DtcaWwfBJfCt0dYQ16yTTBnFXAYWmo/hA71juzA 0TOg== X-Forwarded-Encrypted: i=1; AJvYcCUKBOXGRz1hrzESi9svY9OyxnBbmnIeuDEhyeLOiNbQmZjyRrXMIyTVGrQMvRE+dXjBtfs=@vger.kernel.org, AJvYcCVqnRJTgtZbcQ6PYqToX2OcPWj3qo6YMjUJMIlTeyM81+A8erbE82UOxPiK7kYTUOWPKiUxIf6z@vger.kernel.org, AJvYcCWued9O/I79Kgr0rmItO5u7PxWIzse7eqfWx3iDi4TjxjWLIxtJaCPNAoo8tuty7sqibiUMA7ZKWV/zlw8c@vger.kernel.org X-Gm-Message-State: AOJu0YzNFNpXArWh8OnuA96KN3nnWQadFhJwst7qlHlc2DUJde1Vrlbj N4wlmURr0s/sfVeyIiJIfgxcrGeDrwIvOgK26V1BYYZrv5aSRlNo X-Gm-Gg: ASbGncsRuF3R8v1iSNMBHul9+vivMVHCTybqIcLSow/xJcGylan71IsBRI2Iz0Qo4Mp D8ways4WGEfXg6u5/lZFTRlLdhMewCwPJjWvT90Hzm+teO+BSl0WW8xxcZ256wjkaNhtbeyAYL0 ke7x/D2Oy1JwftZ6ANU6iUY9CaH4A35hCK3Wuv+Ps3GuTcJYmidAyQzj9U/bDEsTOWEyd3A/lL7 lrsktQuCIwu7zFPOYKHRJi1XAekbDrOPHrkUZacRgr8JEGhysxUmg== X-Google-Smtp-Source: AGHT+IH172+O5cWLAzm88+O1nCTzfqDJrh1eXruu2g9IjpXWXMeav1TOvKMsGfuPjCK0wT7Vfh2AJQ== X-Received: by 2002:a17:903:234d:b0:216:70b6:8723 with SMTP id d9443c01a7336-21892a5440cmr215041055ad.44.1734437402485; Tue, 17 Dec 2024 04:10:02 -0800 (PST) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e50299sm58486205ad.143.2024.12.17.04.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:10:02 -0800 (PST) Date: Tue, 17 Dec 2024 20:09:52 +0800 From: Furong Xu <0x1207@gmail.com> To: Vladimir Oltean Cc: Faizal Rahim , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH iwl-next 6/9] igc: Add support for frame preemption verification Message-ID: <20241217200952.000059f2@gmail.com> In-Reply-To: <20241217002254.lyakuia32jbnva46@skbuf> References: <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241217002254.lyakuia32jbnva46@skbuf> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 17 Dec 2024 02:22:54 +0200, Vladimir Oltean wrote: > Anyway, while browsing through this software implementation of a > verification process, I cannot help but think we'd be making a huge > mistake to allow each driver to reimplement it on its own. We just > recently got stmmac to do something fairly clean, with the help and > great perseverence of Furong Xu (now copied). > > I spent a bit of time extracting stmmac's core logic and putting it in > ethtool. If Furong had such good will so as to regression-test the > attached patch, do you think you could use this as a starting place > instead, and implement some ops and call some library methods, instead > of writing the entire logic yourself? > I am quiet busy these days, especially near the end of the year :) Maybe I can help testing the attached patch when the next time net-next opens. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC2F8E7717F for ; Tue, 17 Dec 2024 16:18:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 887954050D; Tue, 17 Dec 2024 16:18:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id hRGBPZlibnpB; Tue, 17 Dec 2024 16:18:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AC9F240533 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1734452288; bh=gk0oaVX4f1jnLyQuTOGkGWyylI3KWC0+6v2HjUrWfmw=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IwXQjbzQcicn+Iw7baCMusjztoHW4IApiW7rCwFAiPT3u6uYQDoTVHUuspUrcoLUW gIeu3SDe3V/F7TO/kUf8iLeNfmExEzW7U3TKP2VHrtPgSZTK3aJbTYOKrpBCSCKtT+ 9DgePoh5zz5oC7r7PjR/8tlK5Zd8cE5Lu0SGIUSMExhyWPJxhcx/2w0bIj2+gSCd+1 EeXhUmLZWwvDmfdpZmWnj5cIL9WFZS/YSqDCimCV6DWPvhw1PiUhPNf3JfmzohCdsN tBnZIu0JRKFBOpOGct/AfT6p3MrcDJPRvtYuuizve4CyocjxNoPlJIts6PP8PPbo8f Riu0Mve3dms3g== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id AC9F240533; Tue, 17 Dec 2024 16:18:08 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 7D466E3 for ; Tue, 17 Dec 2024 12:10:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 47912413D1 for ; Tue, 17 Dec 2024 12:10:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Pu8S-oSlXtKX for ; Tue, 17 Dec 2024 12:10:03 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::630; helo=mail-pl1-x630.google.com; envelope-from=0x1207@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 5B7DB413E2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5B7DB413E2 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5B7DB413E2 for ; Tue, 17 Dec 2024 12:10:03 +0000 (UTC) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-21628b3fe7dso39810925ad.3 for ; Tue, 17 Dec 2024 04:10:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734437402; x=1735042202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gk0oaVX4f1jnLyQuTOGkGWyylI3KWC0+6v2HjUrWfmw=; b=e2lHSFvDCclTiW+7ZEz0glRhwgS4AgfVX7KlUmEM3hm77xnYB/55kQ3UbDNaWYnfYX M6U3j8gefXepWlEDsiiKiOV6Fjb8NzEPF/ckAKV6mOCXTuOH6WbT/BGX/5HceSFO3pXc CvMun/gsvXuglQNPUFx3/zRyKr8g7pllaV+Re0oX3erXFC0pEKfXlHCOgbpNK9C+G29j tzSkIQ4AERTSGpJquTTExhswt5QCHuTq66zej2IkvzA6w0O1Ivhdd6eYsoh3M3LIJah2 jqDJQUaTN8iKiXi8NDaHrK4o1X7tND1By7TRlg6p4qMoa4RBc/u3GDX7pWBa39bobT+y 87dQ== X-Forwarded-Encrypted: i=1; AJvYcCVvk7fInCaIGdoWd2PKYGRS6+Xrq4PYWhb8fwHNQKNgWF3P1tSa2D28/cewy7xNxEGUj9Xpag9uOORtHZ38rCg=@lists.osuosl.org X-Gm-Message-State: AOJu0YwyHdyksn1OqKp3NL1Di4dFcxdmLc6yG7h5upIhDR0G1kND1oDL 4Bg8WT92EmQbg6Ih9/3CV7QyrloM8FuoYOYz+vllbT6n38X+IVaZ X-Gm-Gg: ASbGncsL2OOoqC2YJQ9sytThiO7mHVamBOEYIY21udKEKFkk6KnrAtI5CxxDLQyBJK/ VzfM/Sk/f7y5+F6EvqZDEcetVbKtc9O+gE/gHeJhBSNKQLfj9IPkOToJQSXU7eSdyxEp2QdESZ5 zoknyKdLN/xgUB62mKUCYuy5qt1+Qjn6G04XE0fCf09Sw2mn2yxQdhY9PI5jsRlOgmXNdMvLIAC HVk3UqdWj0lVvM6A9L1YKIqxm+oDNhl7aGLeA+vXmzC1vDYPglCwg== X-Google-Smtp-Source: AGHT+IH172+O5cWLAzm88+O1nCTzfqDJrh1eXruu2g9IjpXWXMeav1TOvKMsGfuPjCK0wT7Vfh2AJQ== X-Received: by 2002:a17:903:234d:b0:216:70b6:8723 with SMTP id d9443c01a7336-21892a5440cmr215041055ad.44.1734437402485; Tue, 17 Dec 2024 04:10:02 -0800 (PST) Received: from localhost ([129.146.253.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1e50299sm58486205ad.143.2024.12.17.04.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:10:02 -0800 (PST) Date: Tue, 17 Dec 2024 20:09:52 +0800 From: Furong Xu <0x1207@gmail.com> To: Vladimir Oltean Cc: Faizal Rahim , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Message-ID: <20241217200952.000059f2@gmail.com> In-Reply-To: <20241217002254.lyakuia32jbnva46@skbuf> References: <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-1-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241216064720.931522-7-faizal.abdul.rahim@linux.intel.com> <20241217002254.lyakuia32jbnva46@skbuf> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 17 Dec 2024 16:18:06 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734437402; x=1735042202; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=gk0oaVX4f1jnLyQuTOGkGWyylI3KWC0+6v2HjUrWfmw=; b=Fab2P4mlroV0UhT1ZyTZpgdAOVi8WEdcBlxRTN5C0fUE+0HPSiC/eCmwe7F2YY7xbb dgwwovxHQJnQ9wQKjoefphjiTyjbAQ4TQseduCw/8uGTCpT0lUKnD8i1+U3cFcQ+ZWNg LlMJqeuXuFX8eldPMY438cm9u63o6Cj7FqDcnqleL0iWSODDncByGblMKo0Vh2FOm/sg Udm/smvO5n+Ir5kdJsCO7xUR185JNvjbPHaFjoR2BQIPiL+N8MgRsRGiq76Uu9AaqrRh cndxHmL0KyisO5lt02zz3aVTBAxkmKl1eQwFnm+KP8BSELmQk5vFoYyD1WE2XtKSf9cO GMrA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Fab2P4ml Subject: Re: [Intel-wired-lan] [PATCH iwl-next 6/9] igc: Add support for frame preemption verification X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 17 Dec 2024 02:22:54 +0200, Vladimir Oltean wrote: > Anyway, while browsing through this software implementation of a > verification process, I cannot help but think we'd be making a huge > mistake to allow each driver to reimplement it on its own. We just > recently got stmmac to do something fairly clean, with the help and > great perseverence of Furong Xu (now copied). > > I spent a bit of time extracting stmmac's core logic and putting it in > ethtool. If Furong had such good will so as to regression-test the > attached patch, do you think you could use this as a starting place > instead, and implement some ops and call some library methods, instead > of writing the entire logic yourself? > I am quiet busy these days, especially near the end of the year :) Maybe I can help testing the attached patch when the next time net-next opens. Thanks.