From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACF05E7717F for ; Tue, 17 Dec 2024 21:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CiYG5i7QbPotEDiwpoez8NA55ZqCOv2bDRM7NgJOnPw=; b=TLZKC0TjGzBOaqtgXbJ2hUf/wA Y2GwFucnk3qcIHhLaYSLTYfs8Um2IS8IeRLWnmH+ErLc5NSbgHGoDWrcdWwn8lLdPwBwGe7GGUlUB QV3UsZQzjD9b2oVkI9N9rXxrExOYDTS2Fbf5CmFBbkPI69ikrKGOPPIfGH0onV2jyUz2w/5sbjOCy 31/r8j6z6H7tvgQXY2A2l8IGdB+u/bjvqRiZR4JClNTpIWrHOArxvECADx4Edu1nAOEEwDJr92LRy A+Mx5I0qfFSPy1GXTiJuQ04N+UeYkWN+lTTmOTJo/MLDCgG7Csd5eleAy61yJWvH6zUu57bgDl01r z7FkyKTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNewH-0000000Eq1u-15LD; Tue, 17 Dec 2024 21:17:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tNevB-0000000Epx3-0pqJ for linux-arm-kernel@lists.infradead.org; Tue, 17 Dec 2024 21:16:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A68DEFEC; Tue, 17 Dec 2024 13:16:27 -0800 (PST) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 621913F7B4; Tue, 17 Dec 2024 13:15:57 -0800 (PST) Date: Tue, 17 Dec 2024 21:15:05 +0000 From: Andre Przywara To: Vasily Khoruzhick Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Maxime Ripard , Roman Beranek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI Message-ID: <20241217211505.7f9c9e4e@minigeek.lan> In-Reply-To: References: <20241215053639.738890-1-anarsoul@gmail.com> <20241215053639.738890-2-anarsoul@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241217_131601_281735_242BA25F X-CRM114-Status: GOOD ( 22.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Dec 2024 10:00:45 -0800 Vasily Khoruzhick wrote: Hi, > On Mon, Dec 16, 2024 at 11:33=E2=80=AFPM Krzysztof Kozlowski wrote: > > > > On Sat, Dec 14, 2024 at 09:34:57PM -0800, Vasily Khoruzhick wrote: =20 > > > These will be used to explicitly select TCON0 clock parent in dts > > > > > > Fixes: ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TC= ON0 mux") > > > Signed-off-by: Vasily Khoruzhick > > > --- > > > drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 -- > > > include/dt-bindings/clock/sun50i-a64-ccu.h | 2 + =20 >=20 > Hi Krzysztof, >=20 > > You cannot combine these changes. =20 >=20 > The patch basically moves defines out from ccu-sun50i-a64.h to > sun50i-a64-ccu.h. How do I split the change without introducing > compilation failure? You can just have the binding part first, adding the (same) definition to the binding headers. As long as the #define's are not conflicting, this is fine. Then remove the now redundant definitions in the kernel headers, with a subsequent patch. Cheers, Andre >=20 > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > > run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. > > Some warnings can be ignored, especially from --strict run, but the code > > here looks like it needs a fix. Feel free to get in touch if the warning > > is not clear. =20 >=20 > Yeah, it is not clear what do you want me to do, assuming the previous > similar change to sun50i-a64-ccu.h did essentially the same, see > 71b597ef5d46a326fb0d5cbfc1c6ff1d73cdc7f9 >=20 > Regards, > Vasily >=20 > > Best regards, > > Krzysztof > > =20 >=20