From: Petr Vorel <pvorel@suse.cz>
To: Zhao Mengmeng <zhaomzhao@126.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] controllers/cpuset: Add backslash to dump full fail log
Date: Tue, 17 Dec 2024 22:48:03 +0100 [thread overview]
Message-ID: <20241217214803.GC29863@pevik> (raw)
In-Reply-To: <20241120005926.1644064-1-zhaomzhao@126.com>
Hi Zhao Mengmeng,
> While debugging LTP cpuset_load_balance_test, when rmdir a path failed,
> it only dumps part of the log, missing the $subdir. Add backslash to fix
> it.
+1 good catch.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Signed-off-by: Zhao Mengmeng <zhaomengmeng@kylinos.cn>
> ---
> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index 567178e3fd52..a374fd71f790 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -195,7 +195,7 @@ cleanup()
> done < "$subdir/tasks"
> rmdir "$subdir"
> if [ $? -ne 0 ]; then
> - tst_brkm TFAIL "Couldn't remove subdir - "
> + tst_brkm TFAIL "Couldn't remove subdir - "\
> "$subdir in the cpuset"
Could we please just join the string?
tst_brkm TFAIL "Couldn't remove subdir - $subdir in the cpuset"
Kind regards,
Petr
> fi
> done
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-12-17 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 0:59 [LTP] [PATCH] controllers/cpuset: Add backslash to dump full fail log Zhao Mengmeng
2024-12-17 21:48 ` Petr Vorel [this message]
2025-04-29 7:55 ` Andrea Cervesato via ltp
2025-05-06 1:03 ` Zhao Mengmeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217214803.GC29863@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhaomzhao@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.