From: Luis Chamberlain <mcgrof@kernel.org>
To: shinichiro.kawasaki@wdc.com
Cc: linux-block@vger.kernel.org, hare@suse.de,
patches@lists.linux.dev, gost.dev@samsung.com, mcgrof@kernel.org
Subject: [PATCH blktests 3/4] tests: use test device min io to support bs > ps
Date: Wed, 18 Dec 2024 03:21:52 -0800 [thread overview]
Message-ID: <20241218112153.3917518-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20241218112153.3917518-1-mcgrof@kernel.org>
When a block device supports a minimum block size > ps we must
ensure we don't issue IOs below what is supported. Just leverage
the min optimal IO to also ensure we use the optimal IO as well.
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
tests/block/003 | 4 +++-
tests/block/007 | 3 ++-
tests/nvme/049 | 5 +++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/block/003 b/tests/block/003
index 2af9b89ec3e5..e57d76271b8b 100755
--- a/tests/block/003
+++ b/tests/block/003
@@ -18,10 +18,12 @@ device_requires() {
}
test_device() {
+ local test_dev_bs=$(_test_dev_min_io $TEST_DEV)
+
echo "Running ${TEST_NAME}"
FIO_PERF_FIELDS=("trim iops")
- _fio_perf --bsrange=4k-4g --rw=randtrim --norandommap --name=discards \
+ _fio_perf --bsrange=${test_dev_bs}-4g --rw=randtrim --norandommap --name=discards \
--filename="$TEST_DEV" --number_ios=200k
echo "Test complete"
diff --git a/tests/block/007 b/tests/block/007
index 3b68d0deec35..793bb4c45c05 100755
--- a/tests/block/007
+++ b/tests/block/007
@@ -31,13 +31,14 @@ cleanup_fallback_device() {
}
run_fio_job() {
+ local test_dev_bs=$(_test_dev_min_io $TEST_DEV)
if _test_dev_is_rotational; then
size="32m"
else
size="1g"
fi
- _fio_perf --bs=4k --rw=randread --norandommap --name=reads \
+ _fio_perf --bs=$test_dev_bs --rw=randread --norandommap --name=reads \
--filename="$TEST_DEV" --size="$size" --direct=1 \
--ioengine=pvsync2 --hipri="$1"
}
diff --git a/tests/nvme/049 b/tests/nvme/049
index 88d4fb122988..6bb731f84fbf 100755
--- a/tests/nvme/049
+++ b/tests/nvme/049
@@ -19,10 +19,11 @@ test_device() {
echo "Running ${TEST_NAME}"
local ngdev=${TEST_DEV/nvme/ng}
+ local test_dev_bs=$(_test_dev_min_io $ngdev)
local common_args=(
--size=1M
--filename="$ngdev"
- --bs=4k
+ --bs=$test_dev_bs
--rw=randread
--numjobs=1
--iodepth=16
@@ -35,7 +36,7 @@ test_device() {
local fio_output
# check security permission
- if ! fio_output=$(fio --name=check --size=4k --filename="$ngdev" \
+ if ! fio_output=$(fio --name=check --bs=$test_dev_bs --size=32k --filename="$ngdev" \
--rw=read --ioengine=io_uring_cmd 2>&1) &&
grep -q -e "Operation not permitted" \
-e "Permission denied" <<< "$fio_output"; then
--
2.43.0
next prev parent reply other threads:[~2024-12-18 11:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 11:21 [PATCH blktests 0/4] enable bs > ps device testing Luis Chamberlain
2024-12-18 11:21 ` [PATCH blktests 1/4] common: add and use min io for fio Luis Chamberlain
2024-12-23 9:37 ` Shinichiro Kawasaki
2025-01-04 4:10 ` Luis Chamberlain
2025-01-07 5:19 ` Shinichiro Kawasaki
2025-02-04 19:06 ` Luis Chamberlain
2024-12-18 11:21 ` [PATCH blktests 2/4] common/xfs: use min io for fs blocksize Luis Chamberlain
2024-12-18 11:21 ` Luis Chamberlain [this message]
2024-12-18 11:21 ` [PATCH blktests 4/4] nvme/053: provide time extension alternative Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218112153.3917518-4-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.