From: Peter Zijlstra <peterz@infradead.org>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Yury Norov <yury.norov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Valentin Schneider <vschneid@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
linux-kernel@vger.kernel.org, Waiman Long <longman@redhat.com>,
x86@kernel.org
Subject: Re: [RFC PATCH v1] stop_machine: Add stop_housekeeping_cpuslocked()
Date: Wed, 18 Dec 2024 18:27:54 +0100 [thread overview]
Message-ID: <20241218172754.GP2354@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241218171531.2217275-1-costa.shul@redhat.com>
On Wed, Dec 18, 2024 at 07:15:31PM +0200, Costa Shulyupin wrote:
> Which synchronizations do these functions require instead of stop_machine?
*sigh*, so you're asking us to do your homework?
But clearly you're not realizing the scope of the thing: stop_machine()
serializes against every preempt_disable() region in the entire kernel.
So you're telling me there isn't a single preempt_disable() region in
the kernel that depends on being before stop_machine() in its entirety?
I know for a fact I've written some in the past 20 years -- what I don't
know if any of them still live and are still relying on it, because I've
also added synchronize_rcu_sched(), which later became synchronize_rcu()
which implies the same, in various parts of the hotplug machinery.
Anyway, without you doing some proper analysis, your patches are going
exactly nowhere.
next prev parent reply other threads:[~2024-12-18 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 17:15 [RFC PATCH v1] stop_machine: Add stop_housekeeping_cpuslocked() Costa Shulyupin
2024-12-18 17:27 ` Peter Zijlstra [this message]
2024-12-18 17:32 ` Frederic Weisbecker
2025-01-06 13:08 ` Costa Shulyupin
2025-01-06 21:24 ` Frederic Weisbecker
2025-01-07 14:40 ` Costa Shulyupin
2024-12-19 21:38 ` Thomas Gleixner
2025-01-04 18:37 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218172754.GP2354@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=costa.shul@redhat.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=neeraj.upadhyay@kernel.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.