From: kernel test robot <lkp@intel.com>
To: Andrew Jones <ajones@ventanamicro.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@rivosinc.com>
Subject: arch/riscv/kvm/vcpu_sbi_sta.c:59:13: sparse: sparse: restricted __le32 degrades to integer
Date: Thu, 19 Dec 2024 17:21:01 +0800 [thread overview]
Message-ID: <202412191745.vbAA5488-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: eabcdba3ad4098460a376538df2ae36500223c1e
commit: f072b272aa27d57cf7fe6fdedb30fb50f391974e RISC-V: KVM: Use correct restricted types
date: 10 months ago
config: riscv-randconfig-r113-20241219 (https://download.01.org/0day-ci/archive/20241219/202412191745.vbAA5488-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20241219/202412191745.vbAA5488-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412191745.vbAA5488-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/riscv/kvm/vcpu_sbi_sta.c:59:13: sparse: sparse: restricted __le32 degrades to integer
>> arch/riscv/kvm/vcpu_sbi_sta.c:59:13: sparse: sparse: restricted __le32 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:59:13: sparse: sparse: cast to restricted __le32
arch/riscv/kvm/vcpu_sbi_sta.c:65:13: sparse: sparse: restricted __le32 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:65:13: sparse: sparse: restricted __le32 degrades to integer
>> arch/riscv/kvm/vcpu_sbi_sta.c:65:13: sparse: sparse: cast from restricted __le32
>> arch/riscv/kvm/vcpu_sbi_sta.c:68:14: sparse: sparse: restricted __le64 degrades to integer
>> arch/riscv/kvm/vcpu_sbi_sta.c:68:14: sparse: sparse: restricted __le64 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:68:14: sparse: sparse: cast to restricted __le64
arch/riscv/kvm/vcpu_sbi_sta.c:72:17: sparse: sparse: restricted __le64 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:72:17: sparse: sparse: restricted __le64 degrades to integer
>> arch/riscv/kvm/vcpu_sbi_sta.c:72:17: sparse: sparse: cast from restricted __le64
arch/riscv/kvm/vcpu_sbi_sta.c:76:9: sparse: sparse: restricted __le32 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:76:9: sparse: sparse: restricted __le32 degrades to integer
arch/riscv/kvm/vcpu_sbi_sta.c:76:9: sparse: sparse: cast from restricted __le32
vim +59 arch/riscv/kvm/vcpu_sbi_sta.c
24
25 void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu)
26 {
27 gpa_t shmem = vcpu->arch.sta.shmem;
28 u64 last_steal = vcpu->arch.sta.last_steal;
29 __le32 __user *sequence_ptr;
30 __le64 __user *steal_ptr;
31 __le32 sequence_le;
32 __le64 steal_le;
33 u32 sequence;
34 u64 steal;
35 unsigned long hva;
36 gfn_t gfn;
37
38 if (shmem == INVALID_GPA)
39 return;
40
41 /*
42 * shmem is 64-byte aligned (see the enforcement in
43 * kvm_sbi_sta_steal_time_set_shmem()) and the size of sbi_sta_struct
44 * is 64 bytes, so we know all its offsets are in the same page.
45 */
46 gfn = shmem >> PAGE_SHIFT;
47 hva = kvm_vcpu_gfn_to_hva(vcpu, gfn);
48
49 if (WARN_ON(kvm_is_error_hva(hva))) {
50 vcpu->arch.sta.shmem = INVALID_GPA;
51 return;
52 }
53
54 sequence_ptr = (__le32 __user *)(hva + offset_in_page(shmem) +
55 offsetof(struct sbi_sta_struct, sequence));
56 steal_ptr = (__le64 __user *)(hva + offset_in_page(shmem) +
57 offsetof(struct sbi_sta_struct, steal));
58
> 59 if (WARN_ON(get_user(sequence_le, sequence_ptr)))
60 return;
61
62 sequence = le32_to_cpu(sequence_le);
63 sequence += 1;
64
> 65 if (WARN_ON(put_user(cpu_to_le32(sequence), sequence_ptr)))
66 return;
67
> 68 if (!WARN_ON(get_user(steal_le, steal_ptr))) {
69 steal = le64_to_cpu(steal_le);
70 vcpu->arch.sta.last_steal = READ_ONCE(current->sched_info.run_delay);
71 steal += vcpu->arch.sta.last_steal - last_steal;
> 72 WARN_ON(put_user(cpu_to_le64(steal), steal_ptr));
73 }
74
75 sequence += 1;
76 WARN_ON(put_user(cpu_to_le32(sequence), sequence_ptr));
77
78 kvm_vcpu_mark_page_dirty(vcpu, gfn);
79 }
80
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-12-19 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 9:21 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-15 10:55 arch/riscv/kvm/vcpu_sbi_sta.c:59:13: sparse: sparse: restricted __le32 degrades to integer kernel test robot
2024-09-26 14:22 kernel test robot
2024-06-23 2:01 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412191745.vbAA5488-lkp@intel.com \
--to=lkp@intel.com \
--cc=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=atishp@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.