From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
<konguyen@redhat.com>, <horms@kernel.org>,
<einstein.xue@synaxg.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
Abhijit Ayarekar <aayarekar@marvell.com>,
Satananda Burla <sburla@marvell.com>
Subject: Re: [PATCH net v3 2/4] octeon_ep: remove firmware stats fetch in ndo_get_stats64
Date: Thu, 19 Dec 2024 19:23:23 -0800 [thread overview]
Message-ID: <20241219192323.4a083d37@kernel.org> (raw)
In-Reply-To: <20241218115111.2407958-3-srasheed@marvell.com>
On Wed, 18 Dec 2024 03:51:09 -0800 Shinas Rasheed wrote:
> The per queue stats are available already and are retrieved
> from register reads during ndo_get_stats64. The firmware stats
> fetch call that happens in ndo_get_stats64() is currently not
> required
Because they are just additional error stats?
No longer reporting errors could cause a regression for monitoring
systems.
next prev parent reply other threads:[~2024-12-20 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 11:51 [PATCH net v3 0/4] Fix race conditions in ndo_get_stats64 Shinas Rasheed
2024-12-18 11:51 ` [PATCH net v3 1/4] octeon_ep: fix " Shinas Rasheed
2024-12-20 3:21 ` Jakub Kicinski
2024-12-18 11:51 ` [PATCH net v3 2/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2024-12-20 3:23 ` Jakub Kicinski [this message]
2024-12-18 11:51 ` [PATCH net v3 3/4] octeon_ep_vf: fix race conditions " Shinas Rasheed
2024-12-20 3:21 ` Jakub Kicinski
2024-12-18 11:51 ` [PATCH net v3 4/4] octeon_ep_vf: remove firmware stats fetch " Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219192323.4a083d37@kernel.org \
--to=kuba@kernel.org \
--cc=aayarekar@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.