From: Jakub Kicinski <kuba@kernel.org>
To: John Ousterhout <ouster@cs.stanford.edu>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH net-next v4 01/12] inet: homa: define user-visible API for Homa
Date: Fri, 20 Dec 2024 11:31:50 -0800 [thread overview]
Message-ID: <20241220113150.26fc7b8f@kernel.org> (raw)
In-Reply-To: <CAGXJAmyW2Mnz1hwvTo7PKsXLVJO6dy_TK-ZtDW1E-Lrds6o+WA@mail.gmail.com>
On Fri, 20 Dec 2024 09:59:53 -0800 John Ousterhout wrote:
> > > I see that "void *" is used in the declaration for struct msghdr
> > > (along with some other pointer types as well) and struct msghdr is
> > > part of several uAPI interfaces, no?
> >
> > Off the top off my head this use is a source of major pain, grep around
> > for compat_msghdr.
>
> How should I go about confirming that this __aligned_u64 is indeed the
> expected convention (sounds like you aren't certain)?
Let me add Arnd Bergmann to the CC list, he will correct me if
I'm wrong. Otherwise you can trust my intuition :)
> Also, any idea why it needs to be aligned rather than just __u64?
The main problem is that if __u64 doesn't force alignment on a 32b
version of a platform the struct may have holes and padding in
different places on 32b vs 64b compat.
Double checking, I don't think that's the case for your structs,
so you can most likely go with a plain __u64.
next prev parent reply other threads:[~2024-12-20 19:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 0:06 [PATCH net-next v4 00/12] Begin upstreaming Homa transport protocol John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 01/12] inet: homa: define user-visible API for Homa John Ousterhout
2024-12-19 1:43 ` Jakub Kicinski
2024-12-19 18:57 ` John Ousterhout
2024-12-19 22:05 ` Przemek Kitszel
2024-12-20 17:25 ` John Ousterhout
2024-12-19 22:32 ` Andrew Lunn
2024-12-20 1:41 ` Jakub Kicinski
2024-12-20 17:59 ` John Ousterhout
2024-12-20 19:31 ` Jakub Kicinski [this message]
2024-12-20 21:12 ` Arnd Bergmann
2024-12-20 23:42 ` John Ousterhout
2024-12-20 23:51 ` John Ousterhout
2024-12-21 13:43 ` Arnd Bergmann
2024-12-23 17:17 ` John Ousterhout
2024-12-20 21:18 ` Andrew Lunn
2024-12-19 21:57 ` Przemek Kitszel
2024-12-17 0:06 ` [PATCH net-next v4 02/12] net: homa: create homa_wire.h John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 03/12] net: homa: create shared Homa header files John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 04/12] net: homa: create homa_pool.h and homa_pool.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 05/12] net: homa: create homa_rpc.h and homa_rpc.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 06/12] net: homa: create homa_peer.h and homa_peer.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 07/12] net: homa: create homa_sock.h and homa_sock.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 08/12] net: homa: create homa_incoming.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 09/12] net: homa: create homa_outgoing.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 10/12] net: homa: create homa_timer.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 11/12] net: homa: create homa_plumbing.c homa_utils.c John Ousterhout
2024-12-17 0:06 ` [PATCH net-next v4 12/12] net: homa: create Makefile and Kconfig John Ousterhout
2024-12-25 2:26 ` kernel test robot
2025-01-06 17:27 ` John Ousterhout
2025-01-06 19:08 ` Andrew Lunn
2025-01-06 21:41 ` Jakub Kicinski
2025-01-06 21:55 ` John Ousterhout
2025-01-06 21:53 ` John Ousterhout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220113150.26fc7b8f@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ouster@cs.stanford.edu \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.