From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>,
netdev@vger.kernel.org, alexanderduyck@fb.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, kernel-team@meta.com
Subject: Re: [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section
Date: Fri, 20 Dec 2024 13:03:38 -0800 [thread overview]
Message-ID: <20241220130338.7c8aca32@kernel.org> (raw)
In-Reply-To: <2a375625-5016-4f4a-a5fa-5a73dc536651@lunn.ch>
On Thu, 19 Dec 2024 09:25:41 +0100 Andrew Lunn wrote:
> On Wed, Dec 18, 2024 at 03:25:58PM -0800, Mohsin Bashir wrote:
> > The CSR dump support leverages the FBNIC_BOUNDS macro, which pads the end
> > condition for each section by adding an offset of 1. However, the RPC RAM
> > section, which is dumped differently from other sections, does not rely
> > on this macro and instead directly uses end boundary address. Hence,
> > subtracting 1 from the end address results in skipping a register.
>
> Maybe it would be better to actually use FBNIC_BOUNDS macro, to make
> it the same as all the others, and so avoid errors like this because
> it is special?
That may require changing the format / contents of the dump a bit
to include unimplemented registers (which would read as ff).
Note that the subject is incorrect, the patch is for net,
so the one-liner fix is more appealing at this stage.
But I may be biased...
next prev parent reply other threads:[~2024-12-20 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 23:25 [PATCH net-next] eth: fbnic: fix csr boundary for RPM RAM section Mohsin Bashir
2024-12-19 7:31 ` Michal Swiatkowski
2024-12-19 8:25 ` Andrew Lunn
2024-12-20 21:03 ` Jakub Kicinski [this message]
2024-12-23 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220130338.7c8aca32@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.