From: kernel test robot <lkp@intel.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Fabio Estevam <festevam@denx.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Jonathan Corbet <corbet@lwn.net>, Serge Hallyn <serge@hallyn.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-security-module@vger.kernel.org,
chrome-platform@lists.linux.dev, devicetree@vger.kernel.org,
kernel@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 04/11] reboot: rename now misleading hw_protection symbols
Date: Fri, 20 Dec 2024 14:56:00 +0800 [thread overview]
Message-ID: <202412201443.inJcQtcl-lkp@intel.com> (raw)
In-Reply-To: <20241219-hw_protection-reboot-v1-4-263a0c1df802@pengutronix.de>
Hi Ahmad,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8]
url: https://github.com/intel-lab-lkp/linux/commits/Ahmad-Fatoum/reboot-replace-__hw_protection_shutdown-bool-action-parameter-with-an-enum/20241219-155416
base: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
patch link: https://lore.kernel.org/r/20241219-hw_protection-reboot-v1-4-263a0c1df802%40pengutronix.de
patch subject: [PATCH 04/11] reboot: rename now misleading hw_protection symbols
config: i386-buildonly-randconfig-003-20241220 (https://download.01.org/0day-ci/archive/20241220/202412201443.inJcQtcl-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241220/202412201443.inJcQtcl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412201443.inJcQtcl-lkp@intel.com/
All warnings (new ones prefixed by >>):
kernel/reboot.c:241: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
kernel/reboot.c:995: warning: Function parameter or struct member 'action' not described in 'hw_failure_emergency_schedule'
kernel/reboot.c:995: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_schedule'
>> kernel/reboot.c:1023: warning: Function parameter or struct member 'action' not described in '__hw_protection_trigger'
>> kernel/reboot.c:1023: warning: Excess function parameter 'shutdown' description in '__hw_protection_trigger'
vim +1023 kernel/reboot.c
dfa19b11385d4c Matti Vaittinen 2021-06-03 1002
dfa19b11385d4c Matti Vaittinen 2021-06-03 1003 /**
c37fda1c195d45 Ahmad Fatoum 2024-12-19 1004 * __hw_protection_trigger - Trigger an emergency system shutdown or reboot
dfa19b11385d4c Matti Vaittinen 2021-06-03 1005 *
79fa723ba84c2b Fabio Estevam 2023-11-29 1006 * @reason: Reason of emergency shutdown or reboot to be printed.
79fa723ba84c2b Fabio Estevam 2023-11-29 1007 * @ms_until_forced: Time to wait for orderly shutdown or reboot before
79fa723ba84c2b Fabio Estevam 2023-11-29 1008 * triggering it. Negative value disables the forced
79fa723ba84c2b Fabio Estevam 2023-11-29 1009 * shutdown or reboot.
79fa723ba84c2b Fabio Estevam 2023-11-29 1010 * @shutdown: If true, indicates that a shutdown will happen
79fa723ba84c2b Fabio Estevam 2023-11-29 1011 * after the critical tempeature is reached.
79fa723ba84c2b Fabio Estevam 2023-11-29 1012 * If false, indicates that a reboot will happen
79fa723ba84c2b Fabio Estevam 2023-11-29 1013 * after the critical tempeature is reached.
dfa19b11385d4c Matti Vaittinen 2021-06-03 1014 *
79fa723ba84c2b Fabio Estevam 2023-11-29 1015 * Initiate an emergency system shutdown or reboot in order to protect
79fa723ba84c2b Fabio Estevam 2023-11-29 1016 * hardware from further damage. Usage examples include a thermal protection.
79fa723ba84c2b Fabio Estevam 2023-11-29 1017 * NOTE: The request is ignored if protection shutdown or reboot is already
79fa723ba84c2b Fabio Estevam 2023-11-29 1018 * pending even if the previous request has given a large timeout for forced
79fa723ba84c2b Fabio Estevam 2023-11-29 1019 * shutdown/reboot.
dfa19b11385d4c Matti Vaittinen 2021-06-03 1020 */
c37fda1c195d45 Ahmad Fatoum 2024-12-19 1021 void __hw_protection_trigger(const char *reason, int ms_until_forced,
d3e5893beaf551 Ahmad Fatoum 2024-12-19 1022 enum hw_protection_action action)
dfa19b11385d4c Matti Vaittinen 2021-06-03 @1023 {
dfa19b11385d4c Matti Vaittinen 2021-06-03 1024 static atomic_t allow_proceed = ATOMIC_INIT(1);
dfa19b11385d4c Matti Vaittinen 2021-06-03 1025
dfa19b11385d4c Matti Vaittinen 2021-06-03 1026 pr_emerg("HARDWARE PROTECTION shutdown (%s)\n", reason);
dfa19b11385d4c Matti Vaittinen 2021-06-03 1027
dfa19b11385d4c Matti Vaittinen 2021-06-03 1028 /* Shutdown should be initiated only once. */
dfa19b11385d4c Matti Vaittinen 2021-06-03 1029 if (!atomic_dec_and_test(&allow_proceed))
07a22b61946f0b Petr Mladek 2022-06-23 1030 return;
dfa19b11385d4c Matti Vaittinen 2021-06-03 1031
dfa19b11385d4c Matti Vaittinen 2021-06-03 1032 /*
dfa19b11385d4c Matti Vaittinen 2021-06-03 1033 * Queue a backup emergency shutdown in the event of
dfa19b11385d4c Matti Vaittinen 2021-06-03 1034 * orderly_poweroff failure
dfa19b11385d4c Matti Vaittinen 2021-06-03 1035 */
595ab92650cc28 Ahmad Fatoum 2024-12-19 1036 hw_failure_emergency_schedule(action, ms_until_forced);
d3e5893beaf551 Ahmad Fatoum 2024-12-19 1037 if (action == HWPROT_ACT_REBOOT)
79fa723ba84c2b Fabio Estevam 2023-11-29 1038 orderly_reboot();
d3e5893beaf551 Ahmad Fatoum 2024-12-19 1039 else
d3e5893beaf551 Ahmad Fatoum 2024-12-19 1040 orderly_poweroff(true);
dfa19b11385d4c Matti Vaittinen 2021-06-03 1041 }
c37fda1c195d45 Ahmad Fatoum 2024-12-19 1042 EXPORT_SYMBOL_GPL(__hw_protection_trigger);
dfa19b11385d4c Matti Vaittinen 2021-06-03 1043
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-12-20 6:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 7:31 [PATCH 00/11] reboot: support runtime configuration of emergency hw_protection action Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 01/11] reboot: replace __hw_protection_shutdown bool action parameter with an enum Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 02/11] reboot: reboot, not shutdown, on hw_protection_reboot timeout Ahmad Fatoum
2024-12-20 6:12 ` kernel test robot
2025-01-06 14:28 ` Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 03/11] docs: thermal: sync hardware protection doc with code Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 04/11] reboot: rename now misleading hw_protection symbols Ahmad Fatoum
2024-12-20 6:56 ` kernel test robot [this message]
2024-12-19 7:31 ` [PATCH 05/11] reboot: indicate whether it is a HARDWARE PROTECTION reboot or shutdown Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 06/11] reboot: add support for configuring emergency hardware protection action Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 07/11] regulator: allow user configuration of " Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 08/11] platform/chrome: cros_ec_lpc: prepare for hw_protection_shutdown removal Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 09/11] dt-bindings: thermal: give OS some leeway in absence of critical-action Ahmad Fatoum
2025-01-02 17:33 ` Rob Herring (Arm)
2024-12-19 7:31 ` [PATCH 10/11] thermal: core: allow user configuration of hardware protection action Ahmad Fatoum
2024-12-19 7:31 ` [PATCH 11/11] reboot: retire hw_protection_reboot and hw_protection_shutdown helpers Ahmad Fatoum
2024-12-22 9:38 ` [PATCH 00/11] reboot: support runtime configuration of emergency hw_protection action Matti Vaittinen
2024-12-22 9:58 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412201443.inJcQtcl-lkp@intel.com \
--to=lkp@intel.com \
--cc=a.fatoum@pengutronix.de \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=serge@hallyn.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.