From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8794318732E for ; Sun, 22 Dec 2024 11:17:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734866270; cv=none; b=mNZFcA9umN1f+K3oR6oMCt+9g/gyPPWRKunro1LkFLLuKW6U0vF1g1V56/IzLjOJ7t2QeBmWll2iIe8dxwLhwL0C2s5sKkg9G38eUgoG6GHVDHe19+4zqzDQ92FN7MPLtmlIHUWqhuuGaQADbx31ROSs+pbYnqVkKBYVgtPokyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734866270; c=relaxed/simple; bh=leZAE4wzkA+0kyQK6eYHeX3SNyaGGOCsAffHfrAWj7c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BqcwFiKMtTgTnZ/XvW8EabnMdMZKX8/XIukhkARH3M0XSZBdMd5CW6N1Ofc1KRiDgkNMOEvVcAqYrf1dKSjPlRogDq11vE7D6luHbwRk7iE+uoEenl/Nn1E7Rmf4cnJ/W6RaeuIFItSMa+igX/L7ydeCejsRS46i3ZlylrInh/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=cjrzkpS3; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cjrzkpS3" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GGxz+F3eFbru4YuWOlPd0i80PztRkAOimbihX75ha2c=; b=cjrzkpS3yIeqGBKnXG9pPQGmQz JS6HPe3xZfuIjSSts1Mjo9wKxA1WLI+Xy2oXt343G5vHYmxgHaUuMHDm6FA+Z7HFA+cMi7Rq5oJBc ZpygIgwmCXU2sXpUvjbSNrxmsvhfb3q3e5GimcCk22dGX8js0JEvxGF5HWKlnAPU11dVKqAyKWz7n R805XsAp/jk94K5Z7OCIO3ut+4AuHVLhTxsWEtyvY8k0LG2LC0+cDNXR23J2S/swhlClyjhN7ADlh /1Ho3OYjvP+CRr/9v/V92k1GtHPtz+NyXZKFtx+Ei1ow5GjSTa942t4j1Axl94aKTTgsIyFP60a1C yV0Jo5kA==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tPJxe-0000000ATKL-3YRn; Sun, 22 Dec 2024 11:17:27 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 484213003AF; Sun, 22 Dec 2024 12:17:26 +0100 (CET) Date: Sun, 22 Dec 2024 12:17:26 +0100 From: Peter Zijlstra To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org Subject: Re: [PATCH 05/10] x86,tlb: use INVLPGB in flush_tlb_all Message-ID: <20241222111726.GV11133@noisy.programming.kicks-ass.net> References: <20241222040717.3096835-1-riel@surriel.com> <20241222040717.3096835-6-riel@surriel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222040717.3096835-6-riel@surriel.com> On Sat, Dec 21, 2024 at 11:06:37PM -0500, Rik van Riel wrote: > The flush_tlb_all() function is not used a whole lot, but we might > as well use broadcast TLB flushing there, too. > > Signed-off-by: Rik van Riel > --- > arch/x86/mm/tlb.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c > index 09980fb17907..bf85cd0590d5 100644 > --- a/arch/x86/mm/tlb.c > +++ b/arch/x86/mm/tlb.c > @@ -1074,6 +1074,11 @@ static void do_flush_tlb_all(void *info) > void flush_tlb_all(void) > { > count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); > + if (static_cpu_has(X86_FEATURE_INVLPGB)) { guard(preempt)(); ? > + invlpgb_flush_all(); > + tlbsync(); > + return; > + } > on_each_cpu(do_flush_tlb_all, NULL, 1); > } > > -- > 2.47.1 >