From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53CA018B47D for ; Sun, 22 Dec 2024 13:44:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734875052; cv=none; b=gZrdWuSQhGBuJmS9u1azPUNF8iVeJDXQd/cQyxG2AJTqxY//y7gSLc/CMQuOPupopBhzJfOt9K0S4nHgvkqcn7vu89F7x4qTgjtRbeu4zdA89jc9RYVSaZyw8rI3lizLPjZUod8S5YQtnabAzXj2Rf5EmIJ/2mc1otjvXum0q2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734875052; c=relaxed/simple; bh=v5M/7S3k02BJgpL20QD7sy4x5ashRmGefisfhJ5jVfg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=ETxXnqfR7qd66wd+9wxGOqjD87CbIT6Q0dDoEFR5LdyuprLRjoaBs5IEKAM2j2HPWo2osBgajibVGYuefEnNz0gC0acY6Yau+5y6LpFF1//xDN6EgjHhGNbgnerO2vX2W3ZsqYHxPds7ahfRkNeXvbXQhlJZtrktA0WFRmGaarE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XW7wlT2x; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XW7wlT2x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734875050; x=1766411050; h=date:from:to:cc:subject:message-id:mime-version; bh=v5M/7S3k02BJgpL20QD7sy4x5ashRmGefisfhJ5jVfg=; b=XW7wlT2xxa7CTyASPkpCcUzvriRAOpFvmSTBr8kXxP9J80Lqyy0PYeAZ PQ9f5Um+8IbPxLAZU+3NKbpwoToixUX84brnYplhW22MxeVQz2HkwAwRy DnoqKohnA41v9tct6n1ElrcdGEMUsBiEiay/6HmDXK5+ORFqH8IbijxbF cTni/kc1TzdWVpNuM4xelq6oC3R14GnKk/8iwj0T3t3/kW7I3vc/hYujA N/cLCKOx5lS5+cSe1zgFrbw+Jbv7lRlQki+sLljYbXQCgtgnXy5UiFSr9 QVQhMDWEi+dgQdpWPfqzuKw9UjkveaVx9f/IThh3AnLiooJPwF90NcgnO Q==; X-CSE-ConnectionGUID: mKBB6/vaSsifz8H48QqxkA== X-CSE-MsgGUID: CaIP+zu5R0qdCRe3yF8KaQ== X-IronPort-AV: E=McAfee;i="6700,10204,11294"; a="46778228" X-IronPort-AV: E=Sophos;i="6.12,255,1728975600"; d="scan'208";a="46778228" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2024 05:44:08 -0800 X-CSE-ConnectionGUID: GyQvwmtiQyupTWwdWNv16Q== X-CSE-MsgGUID: d4qZ+nrXRhal6sfOvteeMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,255,1728975600"; d="scan'208";a="98844330" Received: from lkp-server01.sh.intel.com (HELO a46f226878e0) ([10.239.97.150]) by orviesa009.jf.intel.com with ESMTP; 22 Dec 2024 05:44:07 -0800 Received: from kbuild by a46f226878e0 with local (Exim 4.96) (envelope-from ) id 1tPMFY-0002yv-0N; Sun, 22 Dec 2024 13:44:04 +0000 Date: Sun, 22 Dec 2024 21:43:18 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/dma/pl330.c:2758 pl330_prep_dma_cyclic() error: uninitialized symbol 'dst'. Message-ID: <202412222108.JBncFciA-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Frank Li CC: Vinod Koul tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 48f506ad0b683d3e7e794efa60c5785c4fdc86fa commit: a22fe1d6dec7e98535b97249fdc95c2be79120bb dmaengine: fix is_slave_direction() return false when DMA_DEV_TO_DEV date: 11 months ago :::::: branch date: 14 hours ago :::::: commit date: 11 months ago config: arm-randconfig-r072-20241219 (https://download.01.org/0day-ci/archive/20241222/202412222108.JBncFciA-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202412222108.JBncFciA-lkp@intel.com/ smatch warnings: drivers/dma/pl330.c:2758 pl330_prep_dma_cyclic() error: uninitialized symbol 'dst'. drivers/dma/pl330.c:2758 pl330_prep_dma_cyclic() error: uninitialized symbol 'src'. vim +/dst +2758 drivers/dma/pl330.c b3040e40675ec2c Jassi Brar 2010-05-23 2684 42bc9cf45939c26 Boojin Kim 2011-09-02 2685 static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic( 42bc9cf45939c26 Boojin Kim 2011-09-02 2686 struct dma_chan *chan, dma_addr_t dma_addr, size_t len, 185ecb5f4fd4391 Alexandre Bounine 2012-03-08 2687 size_t period_len, enum dma_transfer_direction direction, 31c1e5a1350ae8d Laurent Pinchart 2014-08-01 2688 unsigned long flags) 42bc9cf45939c26 Boojin Kim 2011-09-02 2689 { fc51446021f42ac Lars-Peter Clausen 2013-07-23 2690 struct dma_pl330_desc *desc = NULL, *first = NULL; 42bc9cf45939c26 Boojin Kim 2011-09-02 2691 struct dma_pl330_chan *pch = to_pchan(chan); f6f2421c0a1cb6c Lars-Peter Clausen 2014-07-06 2692 struct pl330_dmac *pl330 = pch->dmac; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2693 unsigned int i; 42bc9cf45939c26 Boojin Kim 2011-09-02 2694 dma_addr_t dst; 42bc9cf45939c26 Boojin Kim 2011-09-02 2695 dma_addr_t src; 42bc9cf45939c26 Boojin Kim 2011-09-02 2696 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2697 if (len % period_len != 0) fc51446021f42ac Lars-Peter Clausen 2013-07-23 2698 return NULL; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2699 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2700 if (!is_slave_direction(direction)) { f6f2421c0a1cb6c Lars-Peter Clausen 2014-07-06 2701 dev_err(pch->dmac->ddma.dev, "%s:%d Invalid dma direction\n", fc51446021f42ac Lars-Peter Clausen 2013-07-23 2702 __func__, __LINE__); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2703 return NULL; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2704 } fc51446021f42ac Lars-Peter Clausen 2013-07-23 2705 445897cbc9d3e2b Vinod Koul 2018-10-25 2706 pl330_config_write(chan, &pch->slave_config, direction); 445897cbc9d3e2b Vinod Koul 2018-10-25 2707 4d6d74e22096543 Robin Murphy 2017-05-19 2708 if (!pl330_prep_slave_fifo(pch, direction)) 4d6d74e22096543 Robin Murphy 2017-05-19 2709 return NULL; 4d6d74e22096543 Robin Murphy 2017-05-19 2710 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2711 for (i = 0; i < len / period_len; i++) { 42bc9cf45939c26 Boojin Kim 2011-09-02 2712 desc = pl330_get_desc(pch); 42bc9cf45939c26 Boojin Kim 2011-09-02 2713 if (!desc) { 4ad5dd2d7876d79 Bumyong Lee 2021-05-07 2714 unsigned long iflags; 4ad5dd2d7876d79 Bumyong Lee 2021-05-07 2715 f6f2421c0a1cb6c Lars-Peter Clausen 2014-07-06 2716 dev_err(pch->dmac->ddma.dev, "%s:%d Unable to fetch desc\n", 42bc9cf45939c26 Boojin Kim 2011-09-02 2717 __func__, __LINE__); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2718 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2719 if (!first) fc51446021f42ac Lars-Peter Clausen 2013-07-23 2720 return NULL; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2721 4ad5dd2d7876d79 Bumyong Lee 2021-05-07 2722 spin_lock_irqsave(&pl330->pool_lock, iflags); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2723 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2724 while (!list_empty(&first->node)) { fc51446021f42ac Lars-Peter Clausen 2013-07-23 2725 desc = list_entry(first->node.next, fc51446021f42ac Lars-Peter Clausen 2013-07-23 2726 struct dma_pl330_desc, node); f6f2421c0a1cb6c Lars-Peter Clausen 2014-07-06 2727 list_move_tail(&desc->node, &pl330->desc_pool); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2728 } fc51446021f42ac Lars-Peter Clausen 2013-07-23 2729 f6f2421c0a1cb6c Lars-Peter Clausen 2014-07-06 2730 list_move_tail(&first->node, &pl330->desc_pool); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2731 4ad5dd2d7876d79 Bumyong Lee 2021-05-07 2732 spin_unlock_irqrestore(&pl330->pool_lock, iflags); fc51446021f42ac Lars-Peter Clausen 2013-07-23 2733 42bc9cf45939c26 Boojin Kim 2011-09-02 2734 return NULL; 42bc9cf45939c26 Boojin Kim 2011-09-02 2735 } 42bc9cf45939c26 Boojin Kim 2011-09-02 2736 42bc9cf45939c26 Boojin Kim 2011-09-02 2737 switch (direction) { db8196df4bb6f11 Vinod Koul 2011-10-13 2738 case DMA_MEM_TO_DEV: 42bc9cf45939c26 Boojin Kim 2011-09-02 2739 desc->rqcfg.src_inc = 1; 42bc9cf45939c26 Boojin Kim 2011-09-02 2740 desc->rqcfg.dst_inc = 0; 42bc9cf45939c26 Boojin Kim 2011-09-02 2741 src = dma_addr; 4d6d74e22096543 Robin Murphy 2017-05-19 2742 dst = pch->fifo_dma; 42bc9cf45939c26 Boojin Kim 2011-09-02 2743 break; db8196df4bb6f11 Vinod Koul 2011-10-13 2744 case DMA_DEV_TO_MEM: 42bc9cf45939c26 Boojin Kim 2011-09-02 2745 desc->rqcfg.src_inc = 0; 42bc9cf45939c26 Boojin Kim 2011-09-02 2746 desc->rqcfg.dst_inc = 1; 4d6d74e22096543 Robin Murphy 2017-05-19 2747 src = pch->fifo_dma; 42bc9cf45939c26 Boojin Kim 2011-09-02 2748 dst = dma_addr; 42bc9cf45939c26 Boojin Kim 2011-09-02 2749 break; 42bc9cf45939c26 Boojin Kim 2011-09-02 2750 default: fc51446021f42ac Lars-Peter Clausen 2013-07-23 2751 break; 42bc9cf45939c26 Boojin Kim 2011-09-02 2752 } 42bc9cf45939c26 Boojin Kim 2011-09-02 2753 9dc5a315fe515e9 Lars-Peter Clausen 2014-07-06 2754 desc->rqtype = direction; 42bc9cf45939c26 Boojin Kim 2011-09-02 2755 desc->rqcfg.brst_size = pch->burst_sz; 1d48745b192a7a4 Frank Mori Hess 2018-04-18 2756 desc->rqcfg.brst_len = pch->burst_len; aee4d1fac887252 Robert Baldyga 2015-02-11 2757 desc->bytes_requested = period_len; fc51446021f42ac Lars-Peter Clausen 2013-07-23 @2758 fill_px(&desc->px, dst, src, period_len); 42bc9cf45939c26 Boojin Kim 2011-09-02 2759 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2760 if (!first) fc51446021f42ac Lars-Peter Clausen 2013-07-23 2761 first = desc; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2762 else fc51446021f42ac Lars-Peter Clausen 2013-07-23 2763 list_add_tail(&desc->node, &first->node); 42bc9cf45939c26 Boojin Kim 2011-09-02 2764 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2765 dma_addr += period_len; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2766 } fc51446021f42ac Lars-Peter Clausen 2013-07-23 2767 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2768 if (!desc) fc51446021f42ac Lars-Peter Clausen 2013-07-23 2769 return NULL; fc51446021f42ac Lars-Peter Clausen 2013-07-23 2770 fc51446021f42ac Lars-Peter Clausen 2013-07-23 2771 pch->cyclic = true; 42bc9cf45939c26 Boojin Kim 2011-09-02 2772 42bc9cf45939c26 Boojin Kim 2011-09-02 2773 return &desc->txd; 42bc9cf45939c26 Boojin Kim 2011-09-02 2774 } 42bc9cf45939c26 Boojin Kim 2011-09-02 2775 :::::: The code at line 2758 was first introduced by commit :::::: fc51446021f42aca8906e701fc2292965aafcb15 dma: pl330: Fix cyclic transfers :::::: TO: Lars-Peter Clausen :::::: CC: Vinod Koul -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki