From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] pinctrl: bcm63268: Add gpio function
Date: Mon, 23 Dec 2024 04:18:20 +0800 [thread overview]
Message-ID: <202412230343.e5klDKSR-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241207223335.17535-1-kylehendrydev@gmail.com>
References: <20241207223335.17535-1-kylehendrydev@gmail.com>
TO: Kyle Hendry <kylehendrydev@gmail.com>
TO: linus.walleij@linaro.org
CC: linux-gpio@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Kyle Hendry <kylehendrydev@gmail.com>
Hi Kyle,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next linus/master v6.13-rc3 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kyle-Hendry/pinctrl-bcm63268-Add-gpio-function/20241208-063718
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20241207223335.17535-1-kylehendrydev%40gmail.com
patch subject: [PATCH] pinctrl: bcm63268: Add gpio function
:::::: branch date: 2 weeks ago
:::::: commit date: 2 weeks ago
config: arm-randconfig-r072-20241219 (https://download.01.org/0day-ci/archive/20241223/202412230343.e5klDKSR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412230343.e5klDKSR-lkp@intel.com/
smatch warnings:
drivers/pinctrl/bcm/pinctrl-bcm63268.c:638 bcm63268_pinctrl_set_mux() error: uninitialized symbol 'reg'.
drivers/pinctrl/bcm/pinctrl-bcm63268.c:638 bcm63268_pinctrl_set_mux() error: uninitialized symbol 'mask'.
drivers/pinctrl/bcm/pinctrl-bcm63268.c:638 bcm63268_pinctrl_set_mux() error: uninitialized symbol 'val'.
vim +/reg +638 drivers/pinctrl/bcm/pinctrl-bcm63268.c
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 595
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 596 static int bcm63268_pinctrl_set_mux(struct pinctrl_dev *pctldev,
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 597 unsigned selector, unsigned group)
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 598 {
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 599 struct bcm63xx_pinctrl *pc = pinctrl_dev_get_drvdata(pctldev);
0e3db16300fbae5 Andy Shevchenko 2022-06-20 600 const struct pingroup *pg = &bcm63268_groups[group];
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 601 const struct bcm63268_function *f = &bcm63268_funcs[selector];
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 602 unsigned i;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 603 unsigned int reg;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 604 unsigned int val, mask;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 605
0e3db16300fbae5 Andy Shevchenko 2022-06-20 606 for (i = 0; i < pg->npins; i++)
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 607 bcm63268_set_gpio(pc, pg->pins[i]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 608
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 609 switch (f->reg) {
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 610 case BCM63268_LEDCTRL:
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 611 reg = BCM63268_LED_REG;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 612 mask = BIT(pg->pins[0]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 613 val = BIT(pg->pins[0]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 614 break;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 615 case BCM63268_MODE:
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 616 reg = BCM63268_MODE_REG;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 617 mask = BIT(pg->pins[0]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 618 val = BIT(pg->pins[0]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 619 break;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 620 case BCM63268_CTRL:
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 621 reg = BCM63268_CTRL_REG;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 622 mask = BIT(pg->pins[0]);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 623 val = 0;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 624 break;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 625 case BCM63268_BASEMODE:
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 626 reg = BCM63268_BASEMODE_REG;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 627 mask = f->mask;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 628 val = f->mask;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 629 break;
238592f9a24c78b Kyle Hendry 2024-12-07 630 case BCM63268_NOREG:
238592f9a24c78b Kyle Hendry 2024-12-07 631 /*Do nothing, leave registers as default*/
238592f9a24c78b Kyle Hendry 2024-12-07 632 break;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 633 default:
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 634 WARN_ON(1);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 635 return -EINVAL;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 636 }
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 637
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 @638 regmap_update_bits(pc->regs, reg, mask, val);
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 639
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 640 return 0;
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 641 }
155cca1b0794a8f Álvaro Fernández Rojas 2021-03-24 642
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-12-22 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-22 20:18 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-07 22:33 [PATCH] pinctrl: bcm63268: Add gpio function Kyle Hendry
2024-12-09 4:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412230343.e5klDKSR-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.