Re: [PATCH 5/8] gpio: max7360: Add MAX7360 gpio support

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241219-mdb-max7360-support-v1-5-8e8317584121@bootlin.com>
References: <20241219-mdb-max7360-support-v1-5-8e8317584121@bootlin.com>
TO: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
TO: Lee Jones <lee@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: Kamel Bouhara <kamel.bouhara@bootlin.com>
TO: Linus Walleij <linus.walleij@linaro.org>
TO: Bartosz Golaszewski <brgl@bgdev.pl>
TO: Dmitry Torokhov <dmitry.torokhov@gmail.com>
TO: "Uwe Kleine-König" <ukleinek@kernel.org>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-gpio@vger.kernel.org
CC: linux-input@vger.kernel.org
CC: linux-pwm@vger.kernel.org
CC: "Grégory Clement" <gregory.clement@bootlin.com>
CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
CC: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>

Hi Mathieu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8]

url:    https://github.com/intel-lab-lkp/linux/commits/Mathieu-Dubois-Briand/dt-bindings-Add-MAX7360-MFD-device/20241220-002541
base:   78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
patch link:    https://lore.kernel.org/r/20241219-mdb-max7360-support-v1-5-8e8317584121%40bootlin.com
patch subject: [PATCH 5/8] gpio: max7360: Add MAX7360 gpio support
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: loongarch-randconfig-r071-20241222 (https://download.01.org/0day-ci/archive/20241223/202412230526.xbsyoRYK-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412230526.xbsyoRYK-lkp@intel.com/

smatch warnings:
drivers/gpio/gpio-max7360.c:56 max7360_gpio_set_value() error: uninitialized symbol 'val'.
drivers/gpio/gpio-max7360.c:388 max7360_gpio_probe() warn: inconsistent indenting

vim +/val +56 drivers/gpio/gpio-max7360.c

19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  37  
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  38  static void max7360_gpio_set_value(struct gpio_chip *gc,
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  39  				   unsigned int pin, int state)
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  40  {
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  41  	struct max7360_gpio *max7360_gpio = gpiochip_get_data(gc);
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  42  	unsigned int val;
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  43  	int ret;
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  44  
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  45  	if (max7360_gpio->gpio_function == MAX7360_GPIO_COL) {
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  46  		int off = MAX7360_MAX_GPIO - (gc->ngpio - pin);
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  47  
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  48  		ret = regmap_write_bits(max7360_gpio->regmap, MAX7360_REG_PORTS,
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  49  					BIT(off), state ? BIT(off) : 0);
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  50  	} else {
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  51  		ret = regmap_write(max7360_gpio->regmap,
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  52  				   MAX7360_REG_PWMBASE + pin, state ? 0xFF : 0);
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  53  	}
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  54  
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  55  	if (ret)
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19 @56  		dev_err(max7360_gpio->dev,
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  57  			"failed to set value %d on gpio-%d", val, pin);
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  58  }
19f89f1d3446db Mathieu Dubois-Briand 2024-12-19  59  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki