From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Zijun Hu <zijun_hu@icloud.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"James Bottomley" <James.Bottomley@HansenPartnership.com>,
"Thomas Weißschuh" <thomas@t-8ch.de>,
linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-sound@vger.kernel.org, sparclinux@vger.kernel.org,
linux-block@vger.kernel.org, linux-cxl@vger.kernel.org,
linux1394-devel@lists.sourceforge.net, arm-scmi@vger.kernel.org,
linux-efi@vger.kernel.org, linux-gpio@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, linux-hwmon@vger.kernel.org,
linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
netdev@vger.kernel.org, "Zijun Hu" <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()
Date: Mon, 23 Dec 2024 20:45:18 +0000 [thread overview]
Message-ID: <20241223204518.000003ad@huawei.com> (raw)
In-Reply-To: <20241211-const_dfc_done-v4-8-583cc60329df@quicinc.com>
On Wed, 11 Dec 2024 08:08:10 +0800
Zijun Hu <zijun_hu@icloud.com> wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
>
> gpio_sim_dev_match_fwnode() is a simple wrapper of API
> device_match_fwnode().
>
> Remove the needless wrapper and use the API instead.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/gpio/gpio-sim.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
> return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
> }
>
> -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
> -{
> - return device_match_fwnode(dev, data);
> -}
> -
> static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
> {
> struct gpio_sim_chip *chip;
> @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
> if (ret)
> return ret;
>
> - chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
> + chip->dev = device_find_child(dev, swnode, device_match_fwnode);
> if (!chip->dev)
> return -ENODEV;
>
>
next prev parent reply other threads:[~2024-12-23 20:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 0:08 [PATCH v4 00/11] driver core: Constify API device_find_child() Zijun Hu
2024-12-11 0:08 ` [PATCH v4 01/11] libnvdimm: Replace namespace_match() with device_find_child_by_name() Zijun Hu
2024-12-23 20:23 ` Jonathan Cameron
2025-01-02 18:17 ` Fan Ni
2025-01-03 0:29 ` Zijun Hu
2024-12-11 0:08 ` [PATCH v4 02/11] slimbus: core: Constify slim_eaddr_equal() Zijun Hu
2024-12-23 20:25 ` Jonathan Cameron
2024-12-11 0:08 ` [PATCH v4 03/11] bus: fsl-mc: Constify fsl_mc_device_match() Zijun Hu
2024-12-23 20:26 ` Jonathan Cameron
2024-12-24 12:36 ` Zijun Hu
2024-12-11 0:08 ` [PATCH v4 04/11] driver core: Constify API device_find_child() then adapt for various usages Zijun Hu
2024-12-23 7:30 ` Uwe Kleine-König
2024-12-23 20:33 ` Jonathan Cameron
2024-12-24 12:47 ` Zijun Hu
2025-01-02 17:07 ` Mathieu Poirier
2024-12-11 0:08 ` [PATCH v4 05/11] driver core: Simplify API device_find_child_by_name() implementation Zijun Hu
2024-12-23 20:39 ` Jonathan Cameron
2024-12-24 12:55 ` Zijun Hu
2024-12-11 0:08 ` [PATCH v4 06/11] driver core: Remove match_any() Zijun Hu
2024-12-23 20:40 ` Jonathan Cameron
2024-12-11 0:08 ` [PATCH v4 07/11] slimbus: core: Remove of_slim_match_dev() Zijun Hu
2024-12-23 20:44 ` Jonathan Cameron
2024-12-11 0:08 ` [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode() Zijun Hu
2024-12-11 8:18 ` Bartosz Golaszewski
2024-12-23 20:45 ` Jonathan Cameron [this message]
2024-12-11 0:08 ` [PATCH v4 09/11] driver core: Introduce an device matching API device_match_type() Zijun Hu
2024-12-23 20:46 ` Jonathan Cameron
2024-12-11 0:08 ` [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with " Zijun Hu
2024-12-23 20:48 ` Jonathan Cameron
2024-12-24 12:58 ` Zijun Hu
2024-12-11 0:08 ` [PATCH v4 11/11] usb: typec: class: Remove both cable_match() and partner_match() Zijun Hu
2024-12-23 20:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223204518.000003ad@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arm-scmi@vger.kernel.org \
--cc=brgl@bgdev.pl \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=quic_zijuhu@quicinc.com \
--cc=sparclinux@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=ukleinek@kernel.org \
--cc=zijun_hu@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.