From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:664e:b0:1be9:327d:8ee3 with SMTP id l14csp4562480njk; Tue, 24 Dec 2024 00:45:08 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWorLB+8u1je7pBMqNCWDsDm9X2b2VmVFwf13uAJT885Pz+q5Jagd293kDSfZbk4RU9UJkUQ8wx6QpVEQ==@linaro.org X-Google-Smtp-Source: AGHT+IEsC8ngHZscomS1tdb+/agHlSiXjVxWN1onIejPpQyFHVv+R/KurGebZbZ8C/WXfZicwPVM X-Received: by 2002:a05:6214:21ab:b0:6d8:9b7b:14c9 with SMTP id 6a1803df08f44-6dd2330924amr224014796d6.8.1735029908323; Tue, 24 Dec 2024 00:45:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1735029908; cv=none; d=google.com; s=arc-20240605; b=CTY27HHLrES8KTflZwNyvE7meKF3mqXDjREuEd1qWqpZzOGwV+0R8Fx8FxW7pqH4ye 85VmqQ+M/YJa0VcbRAdeuy73fODd/IPryHezuPZ9HQVJNMqAVaYZzC+Qz2XkAcqYhUbC qacMpMPwi/2tvqD5V8KX6l19BeGiBTvadCOGW/p7CXeGtaYTyeu6/q8D9HIB31wDKgzA L8Vw7y1mEil8WRwNNSbcy7RWa63olw/TdgF3XIlboNg9YvFVYX9tjIyOY2q0LlwRJ0CF 871U5Jcrq2LQsJmmjvfzr8VEOoiO4fQiqq90iELiQeCDgaFCo7f6wsxjuCSQoqgqwHuh w95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:from:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:date; bh=3cSKdwkPIks3GzGxFu9yCv/HoZj3pGSjo9OvESJdxRU=; fh=Y17pDK/6T6Pt7lFPimIJaBJOhChisJmNKNRWTthjdS8=; b=dq+7jlNwjnMrHN42OD0nnmVoXRT7oSn1SiMs+wPvWRFDL0XCf/9iXYxi+eMNi0iAOt FGpQ12TH6XrWggUAPxeWcF9lR3wsjJdxLFLbrOeN9xTYb5KPbX5HuF+rDinulQis+rUo 7ls3SStJcJgvGY46KXUBmTjp6dtZRJ4mQSGcnk4BrBmZk23v5lIJJ5ENMmR1LflUJrHS 5hygMhkIvnaKx8JnZ13xtTIrX4iY/z3GFyNnOrKWfNXF2C3BmJduYBbqqufwqpFkcB4A KOUt0S8RCeOIgj+i79RRiBoI8Is7EgLCGDkmNDXRTzPh1xhh3IRX74Yk3/P8IV+ZiHNy Sd1Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6dd1834e0besi128876016d6.380.2024.12.24.00.45.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Dec 2024 00:45:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nongnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ0X4-0001Oh-Nu; Tue, 24 Dec 2024 03:44:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0X3-0001OU-Gy; Tue, 24 Dec 2024 03:44:49 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0X2-000307-1W; Tue, 24 Dec 2024 03:44:49 -0500 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YHT1w2YG6z6LD4K; Tue, 24 Dec 2024 16:43:32 +0800 (CST) Received: from frapeml500003.china.huawei.com (unknown [7.182.85.28]) by mail.maildlp.com (Postfix) with ESMTPS id 6B36E140520; Tue, 24 Dec 2024 16:44:45 +0800 (CST) Received: from localhost (10.195.35.193) by frapeml500003.china.huawei.com (7.182.85.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 24 Dec 2024 09:44:44 +0100 Date: Tue, 24 Dec 2024 08:44:39 +0000 To: Jonathan Cameron CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Message-ID: <20241224084439.00004112@huawei.com> In-Reply-To: <20241223181145.00003b06@huawei.com> References: <20241216175414.1953-1-alireza.sanaee@huawei.com> <20241216175414.1953-7-alireza.sanaee@huawei.com> <20241223181145.00003b06@huawei.com> Organization: Huawei X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.35.193] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500003.china.huawei.com (7.182.85.28) Received-SPF: pass client-ip=185.176.79.56; envelope-from=alireza.sanaee@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Alireza Sanaee From: Alireza Sanaee via Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: 7r2b+qDErhib On Mon, 23 Dec 2024 18:11:45 +0000 Jonathan Cameron wrote: > On Mon, 16 Dec 2024 17:54:13 +0000 > Alireza Sanaee wrote: > > > Test new PPTT topolopy with cache representation. > > > > Signed-off-by: Alireza Sanaee > > --- > > tests/qtest/bios-tables-test.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/tests/qtest/bios-tables-test.c > > b/tests/qtest/bios-tables-test.c index 36e5c0adde..0f72520664 100644 > > --- a/tests/qtest/bios-tables-test.c > > +++ b/tests/qtest/bios-tables-test.c > > @@ -2019,7 +2019,11 @@ static void > > test_acpi_aarch64_virt_tcg_topology(void) .scan_len = 128ULL * 1024 > > * 1024, }; > > > > - test_acpi_one("-cpu cortex-a57 " > > + test_acpi_one("-M > > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster," > > + > > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster," > > + > > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster," > > + > > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster " > > + "-cpu cortex-a57 " > Trivial but is there a reason the cpu must come after machine / -M > bits? If not I'd leave it on first line to reduce the churn in this > patch a little. Noted. Less churn. > > Either way, > > Reviewed-by: Jonathan Cameron > > > > "-smp sockets=1,clusters=2,cores=2,threads=2", > > &data); free_test_data(&data); > > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B3DCE77188 for ; Tue, 24 Dec 2024 08:45:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ0X4-0001Oi-T7; Tue, 24 Dec 2024 03:44:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0X3-0001OU-Gy; Tue, 24 Dec 2024 03:44:49 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ0X2-000307-1W; Tue, 24 Dec 2024 03:44:49 -0500 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YHT1w2YG6z6LD4K; Tue, 24 Dec 2024 16:43:32 +0800 (CST) Received: from frapeml500003.china.huawei.com (unknown [7.182.85.28]) by mail.maildlp.com (Postfix) with ESMTPS id 6B36E140520; Tue, 24 Dec 2024 16:44:45 +0800 (CST) Received: from localhost (10.195.35.193) by frapeml500003.china.huawei.com (7.182.85.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 24 Dec 2024 09:44:44 +0100 Date: Tue, 24 Dec 2024 08:44:39 +0000 To: Jonathan Cameron CC: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 6/7] tests/qtest/bios-table-test: testing new ARM ACPI PPTT topology Message-ID: <20241224084439.00004112@huawei.com> In-Reply-To: <20241223181145.00003b06@huawei.com> References: <20241216175414.1953-1-alireza.sanaee@huawei.com> <20241216175414.1953-7-alireza.sanaee@huawei.com> <20241223181145.00003b06@huawei.com> Organization: Huawei X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.35.193] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500003.china.huawei.com (7.182.85.28) Received-SPF: pass client-ip=185.176.79.56; envelope-from=alireza.sanaee@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Alireza Sanaee From: Alireza Sanaee via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, 23 Dec 2024 18:11:45 +0000 Jonathan Cameron wrote: > On Mon, 16 Dec 2024 17:54:13 +0000 > Alireza Sanaee wrote: > > > Test new PPTT topolopy with cache representation. > > > > Signed-off-by: Alireza Sanaee > > --- > > tests/qtest/bios-tables-test.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/tests/qtest/bios-tables-test.c > > b/tests/qtest/bios-tables-test.c index 36e5c0adde..0f72520664 100644 > > --- a/tests/qtest/bios-tables-test.c > > +++ b/tests/qtest/bios-tables-test.c > > @@ -2019,7 +2019,11 @@ static void > > test_acpi_aarch64_virt_tcg_topology(void) .scan_len = 128ULL * 1024 > > * 1024, }; > > > > - test_acpi_one("-cpu cortex-a57 " > > + test_acpi_one("-M > > virt,smp-cache.0.cache=l1i,smp-cache.0.topology=cluster," > > + > > "smp-cache.1.cache=l1d,smp-cache.1.topology=cluster," > > + > > "smp-cache.2.cache=l2,smp-cache.2.topology=cluster," > > + > > "smp-cache.3.cache=l3,smp-cache.3.topology=cluster " > > + "-cpu cortex-a57 " > Trivial but is there a reason the cpu must come after machine / -M > bits? If not I'd leave it on first line to reduce the churn in this > patch a little. Noted. Less churn. > > Either way, > > Reviewed-by: Jonathan Cameron > > > > "-smp sockets=1,clusters=2,cores=2,threads=2", > > &data); free_test_data(&data); > > } >