From: Stephen Hemminger <stephen@networkplumber.org>
To: Ido Schimmel <idosch@nvidia.com>
Cc: <netdev@vger.kernel.org>, <dsahern@gmail.com>, <petrm@nvidia.com>,
<gnault@redhat.com>
Subject: Re: [PATCH iproute2-next 3/3] iprule: Add flow label support
Date: Tue, 24 Dec 2024 11:34:20 -0800 [thread overview]
Message-ID: <20241224113420.4a8dee6e@fedora> (raw)
In-Reply-To: <20241223082642.48634-4-idosch@nvidia.com>
On Mon, 23 Dec 2024 10:26:42 +0200
Ido Schimmel <idosch@nvidia.com> wrote:
>
> +static void iprule_flowlabel_parse(char *arg, __u32 *flowlabel,
> + __u32 *flowlabel_mask)
> +{
> + char *slash;
> +
> + slash = strchr(arg, '/');
> + if (slash != NULL)
> + *slash = '\0';
> + if (get_u32(flowlabel, arg, 0))
> + invarg("invalid flowlabel\n", arg);
The function invarg already adds a new line at the end
next prev parent reply other threads:[~2024-12-24 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 8:26 [PATCH iproute2-next 0/3] Add flow label support to ip-rule and route get Ido Schimmel
2024-12-23 8:26 ` [PATCH iproute2-next 1/3] Sync uAPI headers Ido Schimmel
2024-12-23 8:26 ` [PATCH iproute2-next 2/3] ip: route: Add IPv6 flow label support Ido Schimmel
2024-12-23 8:26 ` [PATCH iproute2-next 3/3] iprule: Add " Ido Schimmel
2024-12-24 19:34 ` Stephen Hemminger [this message]
2024-12-23 14:59 ` [PATCH iproute2-next 0/3] Add flow label support to ip-rule and route get Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241224113420.4a8dee6e@fedora \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.