From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: <dave.jiang@intel.com>, Huaisheng Ye <huaisheng.ye@intel.com>,
Li Zhijian <lizhijian@fujitsu.com>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v2] cxl/region: Fix region creation for greater than x2 switches
Date: Tue, 24 Dec 2024 16:05:08 +0000 [thread overview]
Message-ID: <20241224160508.00007d9e@huawei.com> (raw)
In-Reply-To: <173378716722.1270362.9546805175813426729.stgit@dwillia2-xfh.jf.intel.com>
On Mon, 09 Dec 2024 15:33:02 -0800
Dan Williams <dan.j.williams@intel.com> wrote:
> From: Huaisheng Ye <huaisheng.ye@intel.com>
>
> The cxl_port_setup_targets() algorithm fails to identify valid target list
> ordering in the presence of 4-way and above switches resulting in
> 'cxl create-region' failures of the form:
<snip>
> Fix the method to calculate @distance by iterativeley multiplying the
> number of targets per switch port. This also follows the algorithm
> recommended here [1].
>
> Fixes: 27b3f8d13830 ("cxl/region: Program target lists")
> Link: http://lore.kernel.org/6538824b52349_7258329466@dwillia2-xfh.jf.intel.com.notmuch [1]
> Signed-off-by: Huaisheng Ye <huaisheng.ye@intel.com>
> Tested-by: Li Zhijian <lizhijian@fujitsu.com>
> [djbw: add a comment explaining 'distance']
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> Changes since the RFC [1]:
> * add a comment to clarify what 'distance' represents (Li Zhijian)
That definitely helps!
prev parent reply other threads:[~2024-12-24 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 23:33 [PATCH v2] cxl/region: Fix region creation for greater than x2 switches Dan Williams
2024-12-24 16:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241224160508.00007d9e@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=huaisheng.ye@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.