From: Stephen Hemminger <stephen@networkplumber.org>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Jingjing Wu <jingjing.wu@intel.com>,
Praveen Shetty <praveen.shetty@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable
Date: Fri, 27 Dec 2024 09:57:03 -0800 [thread overview]
Message-ID: <20241227095703.29fe0052@pi5> (raw)
In-Reply-To: <1735263196-2809-3-git-send-email-andremue@linux.microsoft.com>
On Thu, 26 Dec 2024 17:33:15 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:
> From: Andre Muezerie <andremue@linux.microsoft.com>
> To: Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Jingjing Wu <jingjing.wu@intel.com>, Praveen Shetty <praveen.shetty@intel.com>
> Cc: dev@dpdk.org, Andre Muezerie <andremue@linux.microsoft.com>
> Subject: [PATCH 2/3] drivers/common: add diagnostics macros to make code portable
> Date: Thu, 26 Dec 2024 17:33:15 -0800
> X-Mailer: git-send-email 1.8.3.1
>
> It was a common pattern to have "GCC diagnostic ignored" pragmas
> sprinkled over the code and only activate these pragmas for certain
> compilers (gcc and clang). Clang supports GCC’s pragma for
> compatibility with existing source code, so #pragma GCC diagnostic
> and #pragma clang diagnostic are synonyms for Clang
> (https://clang.llvm.org/docs/UsersManual.html).
As much as possible, these should be fixed. Disabling warnings hides too many
pre-existing bugs.
next prev parent reply other threads:[~2024-12-27 17:57 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 1:33 [PATCH 0/3] add diagnostics macros to make code portable Andre Muezerie
2024-12-27 1:33 ` [PATCH 1/3] lib/eal: " Andre Muezerie
2024-12-27 1:33 ` [PATCH 2/3] drivers/common: " Andre Muezerie
2024-12-27 17:57 ` Stephen Hemminger [this message]
2024-12-27 19:43 ` Andre Muezerie
2024-12-27 1:33 ` [PATCH 3/3] drivers/net: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 0/3] " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 1/3] lib/eal: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 2/3] drivers/common: " Andre Muezerie
2024-12-28 0:45 ` [PATCH v2 3/3] drivers/net: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 0/3] " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 1/3] lib/eal: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 2/3] drivers/common: " Andre Muezerie
2024-12-28 3:18 ` [PATCH v3 3/3] drivers/net: " Andre Muezerie
2024-12-30 15:59 ` [PATCH v4 0/3] " Andre Muezerie
2024-12-30 15:59 ` [PATCH v4 1/3] lib/eal: " Andre Muezerie
2024-12-30 15:59 ` [PATCH v4 2/3] drivers/common: " Andre Muezerie
2024-12-30 15:59 ` [PATCH v4 3/3] drivers/net: " Andre Muezerie
2024-12-30 17:44 ` [PATCH v4 0/3] " Stephen Hemminger
2024-12-31 18:55 ` [PATCH v5 " Andre Muezerie
2024-12-31 18:55 ` [PATCH v5 1/3] lib/eal: " Andre Muezerie
2024-12-31 18:55 ` [PATCH v5 2/3] drivers/common: " Andre Muezerie
2024-12-31 18:55 ` [PATCH v5 3/3] drivers/net: " Andre Muezerie
2024-12-31 20:15 ` [PATCH v6 0/3] " Andre Muezerie
2024-12-31 20:15 ` [PATCH v6 1/3] lib/eal: " Andre Muezerie
2024-12-31 20:15 ` [PATCH v6 2/3] drivers/common: " Andre Muezerie
2024-12-31 20:15 ` [PATCH v6 3/3] drivers/net: " Andre Muezerie
2024-12-31 22:30 ` [PATCH v7 0/3] " Andre Muezerie
2024-12-31 22:30 ` [PATCH v7 1/3] lib/eal: " Andre Muezerie
2024-12-31 22:30 ` [PATCH v7 2/3] drivers/common: " Andre Muezerie
2024-12-31 22:30 ` [PATCH v7 3/3] drivers/net: " Andre Muezerie
2025-01-01 0:48 ` [PATCH v8 0/3] " Andre Muezerie
2025-01-01 0:48 ` [PATCH v8 1/3] lib/eal: " Andre Muezerie
2025-01-01 0:48 ` [PATCH v8 2/3] drivers/common: " Andre Muezerie
2025-01-01 0:48 ` [PATCH v8 3/3] drivers/net: " Andre Muezerie
2025-01-01 3:36 ` [PATCH v9 0/3] " Andre Muezerie
2025-01-01 3:36 ` [PATCH v9 1/3] lib/eal: " Andre Muezerie
2025-01-01 3:36 ` [PATCH v9 2/3] drivers/common: " Andre Muezerie
2025-01-01 3:36 ` [PATCH v9 3/3] drivers/net: " Andre Muezerie
2025-01-03 0:12 ` [PATCH v10 0/3] " Andre Muezerie
2025-01-03 0:12 ` [PATCH v10 1/3] lib/eal: " Andre Muezerie
2025-01-03 0:12 ` [PATCH v10 2/3] drivers/common: " Andre Muezerie
2025-01-03 0:12 ` [PATCH v10 3/3] drivers/net: " Andre Muezerie
2025-01-03 15:36 ` [PATCH v11 0/3] " Andre Muezerie
2025-01-03 15:36 ` [PATCH v11 1/3] lib/eal: " Andre Muezerie
2025-01-03 15:36 ` [PATCH v11 2/3] drivers/common: " Andre Muezerie
2025-01-03 15:36 ` [PATCH v11 3/3] drivers/net: " Andre Muezerie
2025-01-03 19:24 ` [PATCH v11 0/3] " Stephen Hemminger
2025-01-03 21:26 ` Andre Muezerie
2025-01-06 11:00 ` Bruce Richardson
2025-01-08 2:46 ` Andre Muezerie
2025-01-08 9:20 ` Bruce Richardson
2025-01-14 19:20 ` Andre Muezerie
2025-01-15 11:11 ` Bruce Richardson
2025-01-15 4:27 ` [PATCH v12 " Andre Muezerie
2025-01-15 4:27 ` [PATCH v12 1/3] lib/eal: " Andre Muezerie
2025-01-15 9:05 ` Morten Brørup
2025-01-15 4:27 ` [PATCH v12 2/3] drivers/common: " Andre Muezerie
2025-01-15 11:13 ` Bruce Richardson
2025-01-15 4:27 ` [PATCH v12 3/3] drivers/net: " Andre Muezerie
2025-01-16 1:55 ` [PATCH v13 0/3] " Andre Muezerie
2025-01-16 1:55 ` [PATCH v13 1/3] eal: " Andre Muezerie
2025-01-16 1:55 ` [PATCH v13 2/3] drivers/common: " Andre Muezerie
2025-01-16 1:55 ` [PATCH v13 3/3] drivers/net: " Andre Muezerie
2025-01-16 8:57 ` Bruce Richardson
2025-01-18 3:07 ` Andre Muezerie
2025-01-16 9:08 ` Morten Brørup
2025-01-17 3:56 ` Andre Muezerie
2025-01-18 3:05 ` Andre Muezerie
2025-01-16 8:58 ` [PATCH v13 0/3] " Bruce Richardson
2025-01-18 2:46 ` [PATCH v14 " Andre Muezerie
2025-01-18 2:46 ` [PATCH v14 1/3] eal: " Andre Muezerie
2025-01-18 2:46 ` [PATCH v14 2/3] drivers/common: " Andre Muezerie
2025-01-18 2:46 ` [PATCH v14 3/3] drivers/net: " Andre Muezerie
2025-01-18 21:55 ` [PATCH v15 0/3] " Andre Muezerie
2025-01-18 21:55 ` [PATCH v15 1/3] eal: " Andre Muezerie
2025-01-21 9:53 ` Morten Brørup
2025-01-21 14:28 ` Andre Muezerie
2025-01-21 14:41 ` Morten Brørup
2025-01-21 20:17 ` Andre Muezerie
2025-01-21 15:01 ` Stephen Hemminger
2025-01-18 21:55 ` [PATCH v15 2/3] drivers/common: " Andre Muezerie
2025-01-18 21:55 ` [PATCH v15 3/3] drivers/net: " Andre Muezerie
2025-01-21 22:36 ` [PATCH v16 0/3] " Andre Muezerie
2025-01-21 22:36 ` [PATCH v16 1/3] eal: " Andre Muezerie
2025-01-23 8:07 ` Morten Brørup
2025-01-21 22:36 ` [PATCH v16 2/3] drivers/common: " Andre Muezerie
2025-01-23 8:09 ` Morten Brørup
2025-01-21 22:36 ` [PATCH v16 3/3] drivers/net: " Andre Muezerie
2025-01-23 8:09 ` Morten Brørup
2025-01-29 21:07 ` Ali Alnubani
2025-01-29 21:10 ` Ali Alnubani
2025-01-30 3:37 ` Andre Muezerie
2025-01-30 7:28 ` Ali Alnubani
2025-01-29 13:26 ` [PATCH v16 0/3] " David Marchand
2025-01-29 14:16 ` David Marchand
2025-01-29 17:48 ` Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241227095703.29fe0052@pi5 \
--to=stephen@networkplumber.org \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=praveen.shetty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.