Re: [PATCH net-next 0/4] selftests/net: packetdrill: import multiple tests

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 24 Dec 2024 10:59:38 -0500 Willem de Bruijn wrote:
> > > Thanks. It does not seem to resolve the flakes.
> > > 
> > > At this point I think the best path is to run them in debug mode to
> > > get coverage, but ignore errors. With the below draft patch, error
> > > output is still logged. For instance:
> > > 
> > > # tcp_timestamping_partial.pkt:58: runtime error in recvmsg call: Bad timestamp 0 in scm_timestamping 0: expected=1734924748967958 (20000) actual=1734924748982069 (34111) start=1734924748947958
> > > # ok 2 ipv6 # SKIP  
> > 
> > Makes sense. Can we make this XFAIL instead of SKIP, tho?
> > Not exactly accurate but we try to use SKIP for reporting env / setup
> > problems like missing commands. We have FAIL_TO_XFAIL and
> > xfail_on_slow() in the lib for netdev bash tests, already.  
> 
> Sounds good. I'll add a ktap_test_xfail() to stay with that API.
> I see no clean way to make use of xfail_on_slow directly.

Ack.

> When net-next reopens, unless the noisy dash is annoying.

No huge rush, once we mark the test as ignored it's not very annoying.
As long as we have a fix before the next merge window we'll be good.