From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D76D1F37DC for ; Fri, 27 Dec 2024 13:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735307607; cv=none; b=Bo97BTD1Sj4sb3xR8ciF+tfjRzYPdOTqVioUN+TVo30KzNh0k2vTBJOuPYCgvVwM80EKd8LFGeHlbH+dkvLZdYTUtlpe4Cth87KMFE2dfe1WeCh7sLMRi9d/fy+iwl2ZWO24QzFSDW8I4KfNC7Ig1msQBcG9WbjpyrcNMngiyQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735307607; c=relaxed/simple; bh=Zn4Ttbnu/Nrmsh7jgj0bLUIbp/RTt3ghPbunby9abw8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dXuOx63EWujjmb0BbKx81utidNHtJycuPXNVN/cEAig4ZXfNM1NBrN7F62rjJTlFMPsaHnhhrCQxoMRVlZlGy7e6EObV+JKZMJdUuDucodLkJuqFhLcBhL89HKC2WKArk9A761OmG5oh8V9XA+u+rvLCRI6ZH3Bgo0VjHOIj304= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LSZmDUVt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LSZmDUVt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC01BC4CED0; Fri, 27 Dec 2024 13:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1735307607; bh=Zn4Ttbnu/Nrmsh7jgj0bLUIbp/RTt3ghPbunby9abw8=; h=From:To:Cc:Subject:Date:Reply-to:From; b=LSZmDUVtTRK6wUBbpBz5wTrBtrh4pgj0qWXF8myE0GbdTJ+qQvKrv1BEjW/aoC4K4 mWa6LPiTGn0Luzr7cWgz08mHY4Z3gKLTID7Y0h+gdvNC0+eOKa8GUqlTcvK+LW61Zf jDrOIIyGO8kebADhQ4iGEDnjPxTyidMm5EkM5t5E= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-53167: nfs/blocklayout: Don't attempt unregister for invalid block device Date: Fri, 27 Dec 2024 14:52:13 +0100 Message-ID: <2024122715-CVE-2024-53167-aea5@gregkh> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3035; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=Zn4Ttbnu/Nrmsh7jgj0bLUIbp/RTt3ghPbunby9abw8=; b=owGbwMvMwCRo6H6F97bub03G02pJDOl5G/lDVzx7XLs4zfrZ9q9CxXc6P9RWH/Z5yhbvO20hz ++3p5ae6IhlYRBkYpAVU2T5so3n6P6KQ4pehranYeawMoEMYeDiFICJNIkxLNi23GhHltuEKQdO 5N1kMRQXYZpjHs8wP16wrPxtnwjvwq5SLQfDLtPY7zGRAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: nfs/blocklayout: Don't attempt unregister for invalid block device Since commit d869da91cccb ("nfs/blocklayout: Fix premature PR key unregistration") an unmount of a pNFS SCSI layout-enabled NFS may dereference a NULL block_device in: bl_unregister_scsi+0x16/0xe0 [blocklayoutdriver] bl_free_device+0x70/0x80 [blocklayoutdriver] bl_free_deviceid_node+0x12/0x30 [blocklayoutdriver] nfs4_put_deviceid_node+0x60/0xc0 [nfsv4] nfs4_deviceid_purge_client+0x132/0x190 [nfsv4] unset_pnfs_layoutdriver+0x59/0x60 [nfsv4] nfs4_destroy_server+0x36/0x70 [nfsv4] nfs_free_server+0x23/0xe0 [nfs] deactivate_locked_super+0x30/0xb0 cleanup_mnt+0xba/0x150 task_work_run+0x59/0x90 syscall_exit_to_user_mode+0x217/0x220 do_syscall_64+0x8e/0x160 This happens because even though we were able to create the nfs4_deviceid_node, the lookup for the device was unable to attach the block device to the pnfs_block_dev. If we never found a block device to register, we can avoid this case with the PNFS_BDEV_REGISTERED flag. Move the deref behind the test for the flag. The Linux kernel CVE team has assigned CVE-2024-53167 to this issue. Affected and fixed versions =========================== Issue introduced in 6.11 with commit d869da91cccb90320e101a2758f1e2b3803ade5c and fixed in 6.11.11 with commit 3402704a424f34bbcca7f4a4503859357f422217 Issue introduced in 6.11 with commit d869da91cccb90320e101a2758f1e2b3803ade5c and fixed in 6.12.2 with commit faa4bacfaeed827a4ca8cb8529a3ce65a9e8ef46 Issue introduced in 6.11 with commit d869da91cccb90320e101a2758f1e2b3803ade5c and fixed in 6.13-rc1 with commit 3a4ce14d9a6b868e0787e4582420b721c04ee41e Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-53167 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: fs/nfs/blocklayout/dev.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/3402704a424f34bbcca7f4a4503859357f422217 https://git.kernel.org/stable/c/faa4bacfaeed827a4ca8cb8529a3ce65a9e8ef46 https://git.kernel.org/stable/c/3a4ce14d9a6b868e0787e4582420b721c04ee41e