From: Greg KH <gregkh@linuxfoundation.org>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
heikki.krogerus@linux.intel.com, dmitry.baryshkov@linaro.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] usb: typec: ucsi: make yoga_c630_ucsi_ops be static
Date: Fri, 27 Dec 2024 08:54:25 +0100 [thread overview]
Message-ID: <2024122743-operable-treading-aa03@gregkh> (raw)
In-Reply-To: <2ffd08092fabaed0bea8b7a5e19e5c9464e76077.1735278513.git.xiaopei01@kylinos.cn>
On Fri, Dec 27, 2024 at 01:51:51PM +0800, Pei Xiao wrote:
> sparse warnings:
> drivers/usb/typec/ucsi/ucsi_yoga_c630.c:101:30: sparse: sparse:
> symbol 'yoga_c630_ucsi_ops' was not declared. Should it be static?
>
That's a nice warning message, but doesn't explain what this change is
actually doing. Please read the kernel documentation for how to
properly write a changelog commit for what needs to go here.
thanks,
greg k-h
next prev parent reply other threads:[~2024-12-27 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 5:51 [PATCH] usb: typec: ucsi: make yoga_c630_ucsi_ops be static Pei Xiao
2024-12-27 7:54 ` Greg KH [this message]
2024-12-27 8:54 ` [PATCH V2] " Pei Xiao
2024-12-31 2:38 ` [PATCH] " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024122743-operable-treading-aa03@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.