All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alvaro Kuolas <kuolas@gmail.com>
Cc: regressions@lists.linux.dev
Subject: Re: Longer boot times with kernel 6.11.7 and newer (including 6.12.6).
Date: Fri, 27 Dec 2024 09:01:06 +0100	[thread overview]
Message-ID: <2024122755-status-provolone-58f2@gregkh> (raw)
In-Reply-To: <CAKUwrzDtcu2JGdVve0BF9nUR-25M3bZrSyJ6xLLiwjCehmWCxw@mail.gmail.com>

On Thu, Dec 26, 2024 at 06:33:44PM -0300, Alvaro Kuolas wrote:
> /////////////////////////////////////////////////////////////////////////////////
> bisecting the regression ended in this commit:
> /////////////////////////////////////////////////////////////////////////////////
> 
> cfc72b86fa20cbf44d2b6cc27b35eb15080232ab is the first bad commit
> commit cfc72b86fa20cbf44d2b6cc27b35eb15080232ab
> Author: Greg Kroah-Hartman <gregkh>
> Date:   Tue Oct 29 01:23:04 2024 +0100
> 
>     Revert "driver core: Fix uevent_show() vs driver detach race"
> 
>     commit 9a71892cbcdb9d1459c84f5a4c722b14354158a5 upstream.
> 
>     This reverts commit 15fffc6a5624b13b428bb1c6e9088e32a55eb82c.
> 
>     This commit causes a regression, so revert it for now until it can come
>     back in a way that works for everyone.
> 
>     Link:
> https://lore.kernel.org/all/172790598832.1168608.4519484276671503678.stgit@dwillia2-xfh.jf.intel.com/
>     Fixes: 15fffc6a5624 ("driver core: Fix uevent_show() vs driver detach
> race")
>     Signed-off-by: Greg Kroah-Hartman <gregkh>
> 
>  drivers/base/core.c   | 13 +++++--------
>  drivers/base/module.c |  4 ----
>  2 files changed, 5 insertions(+), 12 deletions(-)
> 
> /////////////////////////////////////////////////////////////////////////////////
>  - Building the latest git kernel without this commit:
> 
> Reverting the commit on 6.13.0-rc4 works as expected.

"as expected" is what, faster boot?

And yes, this will slow things down as we add back the lock we had
removed as we had reports of real regressions with this change.  Sorry,
but a slow down is better than a non-working system, and in fact, you
are just back to the same speed you were before this commit was added,
so it shouldn't be that big of an issue.

In other words, we can't revert this revert, sorry.
If you could help out in fixing the issue that this original change
caused, that would be great, as then we could add it, and the fix, to
the tree and your speed would come back.

But really, upower taking that long at boot time feels very odd.  What
is it attempting to do?

thanks,

greg k-h

  reply	other threads:[~2024-12-27  8:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-26 17:51 Longer boot times with kernel 6.11.7 and newer (including 6.12.6) Alvaro Kuolas
2024-12-26 21:33 ` Alvaro Kuolas
2024-12-27  8:01   ` Greg KH [this message]
2024-12-27 12:37     ` Alvaro Kuolas
     [not found]     ` <CAKUwrzA2ue3g3Ys=Vg=eeunE1mw-RSockLPoqnU=F6jB1jjVBw@mail.gmail.com>
2024-12-27 12:40       ` Greg KH
2024-12-27 15:28         ` Alvaro Kuolas
2024-12-27  7:58 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024122755-status-provolone-58f2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=kuolas@gmail.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.