Re: [PATCH 20/20] saner replacement for debugfs_rename()

[Al Viro <viro@zeniv.linux.org.uk>]

On Sun, Dec 29, 2024 at 08:12:23AM +0000, Al Viro wrote:

> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
> index b19492a7f6ad..2b78be129770 100644
> --- a/drivers/net/bonding/bond_debugfs.c
> +++ b/drivers/net/bonding/bond_debugfs.c
> @@ -63,13 +63,8 @@ void bond_debug_unregister(struct bonding *bond)
>  
>  void bond_debug_reregister(struct bonding *bond)
>  {
> -	struct dentry *d;
> -
> -	d = debugfs_rename(bonding_debug_root, bond->debug_dir,
> -			   bonding_debug_root, bond->dev->name);
> -	if (!IS_ERR(d)) {
> -		bond->debug_dir = d;
> -	} else {
> +	err = debugfs_change_name(bond->debug_dir, "%s", bond->dev->name);

That should be
+	int err = debugfs_change_name(bond->debug_dir, "%s", bond->dev->name);

obviously...