From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
buildroot@buildroot.org,
Adrian Perez de Castro <aperez@igalia.com>
Subject: Re: [Buildroot] [PATCH v3 2/2] package/webkitgtk: bump to 2.46.4
Date: Sun, 29 Dec 2024 23:02:56 +0100 [thread overview]
Message-ID: <20241229230256.609289ea@windsurf> (raw)
In-Reply-To: <CACXRmJi-K=k+bwwhtVEjAOc6wEJaS1rg_5cDFwMY2nZmR24KVQ@mail.gmail.com>
Hello Thomas,
On Tue, 17 Dec 2024 23:20:47 +0100
Thomas Devoogdt <thomas@devoogdt.com> wrote:
> I discovered that dropping "pkgdatadir" in the
> package/pkgconf/0001-Only-prefix-with-the-sysroot-a-subset-of-variables.patch
> fixes the problem.
> It's btw the same key that was added years ago by commit
> 3e74c1312d35866c05813b4690412548eaaff61a.
>
> It fixed this error back then:
>
> Making all in xwayland
> make[3]: Entering directory
> '/home/buildroot/br5/output/build/xserver_xorg-server-1.19.0/hw/xwayland'
> make[3]: *** No rule to make target
> '/usr/share/wayland-protocols/unstable/relative-pointer/relative-pointer-unstable-v1.xml',
> needed by 'relative-pointer-unstable-v1-client-protocol.h'. Stop.
>
> It's the same wayland-protocols that now give me those problems. So I
> think that we can just drop "pkgdatadir" from the patch list.
Do you have more details about "the same wayland-protocols that now
give me those problems" ? Do you have a defconfig that exhibits the
issue?
Essentially, I'm obviously concerned by the side effect of changing how
this pkgdatadir pkg-config variable gets handled. Your change will fix
some stuff for sure, but will it break something else?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-12-29 22:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 12:07 [Buildroot] [PATCH v1] package/webkitgtk: bump to 2.44.3 Thomas Devoogdt
2024-09-01 14:13 ` Adrian Perez de Castro
2024-09-05 20:47 ` Thomas Petazzoni via buildroot
2024-09-17 20:33 ` [Buildroot] [PATCH v2] package/webkitgtk: bump to 2.44.4 Thomas Devoogdt
2024-12-16 18:17 ` [Buildroot] [PATCH v3 1/2] " Thomas Devoogdt
2024-12-16 18:17 ` [Buildroot] [PATCH v3 2/2] package/webkitgtk: bump to 2.46.4 Thomas Devoogdt
2024-12-16 21:28 ` Thomas Devoogdt
2024-12-16 21:40 ` Thomas Devoogdt
2024-12-17 22:20 ` Thomas Devoogdt
2024-12-18 8:43 ` [Buildroot] [PATCH v1] package/pkgconf: fix sysroot being prepended twice to the pkgdatadir path Thomas Devoogdt
2025-02-04 12:41 ` Thomas Devoogdt
2025-02-26 14:38 ` Peter Korsgaard
2025-02-26 18:14 ` Thomas Devoogdt
2025-03-13 20:38 ` Peter Korsgaard
2024-12-29 22:02 ` Thomas Petazzoni via buildroot [this message]
2024-12-30 17:31 ` [Buildroot] [PATCH v3 2/2] package/webkitgtk: bump to 2.46.4 Thomas Devoogdt
2025-01-06 15:39 ` Thomas Petazzoni via buildroot
2025-03-02 19:56 ` Thomas Devoogdt
2025-03-12 19:01 ` Peter Korsgaard
2025-03-22 7:29 ` Peter Korsgaard
2025-02-04 15:20 ` [Buildroot] [PATCH v3 1/2] package/webkitgtk: bump to 2.44.4 Peter Korsgaard
2025-02-07 19:48 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241229230256.609289ea@windsurf \
--to=buildroot@buildroot.org \
--cc=aperez@igalia.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.devoogdt@barco.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas@devoogdt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.