From: Kees Cook <kees@kernel.org>
To: Nam Cao <namcao@linutronix.de>
Cc: Shuah Khan <shuah@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Dylan Hatch <dylanbhatch@google.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
John Ogness <john.ogness@linutronix.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 2/2] selftests: coredump: Add stackdump test
Date: Mon, 30 Dec 2024 10:43:39 -0800 [thread overview]
Message-ID: <202412301041.E4D0C5D8C@keescook> (raw)
In-Reply-To: <d4b5d4c69eebd694f68ca8e7b92309d60adbe02a.1735550994.git.namcao@linutronix.de>
On Mon, Dec 30, 2024 at 11:17:31AM +0100, Nam Cao wrote:
> Add a test which checks that the kstkesp field in /proc/pid/stat can be
> read for all threads of a coredumping process.
>
> For full details including the motivation for this test and how it works,
> see the README file added by this commit.
This is great! One tiny nit below...
> +#define STACKDUMP_FILE "/tmp/kselftest_stackdump"
Please move this to the local directory (and have the Makefile and/or
test itself clean it up). (Or use mkstemp()) I don't want to have "well
known" filenames appearing in /tmp for selftests.
-Kees
--
Kees Cook
prev parent reply other threads:[~2024-12-30 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 10:17 [PATCH v2 0/2] fix reading ESP during coredump Nam Cao
2024-12-30 10:17 ` [PATCH v2 1/2] fs/proc: do_task_stat: Fix ESP not readable " Nam Cao
2024-12-30 18:43 ` Kees Cook
2024-12-30 10:17 ` [PATCH v2 2/2] selftests: coredump: Add stackdump test Nam Cao
2024-12-30 18:43 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412301041.E4D0C5D8C@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dylanbhatch@google.com \
--cc=ebiederm@xmission.com \
--cc=john.ogness@linutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=oleg@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.